github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(webdriver): emit RequestServedFromCache for requests (#12104)

Browse Source
This commit is contained in:
Nikolay Vitkov 2024-03-19 16:25:33 +01:00 committed by GitHub
parent 73f3f4e173
commit 6ba6bef1b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/puppeteer-core/src/bidi/HTTPRequest.ts
View File

@ -68,7 +68,7 @@ export class BidiHTTPRequest extends HTTPRequest {
}
override resourceType(): ResourceType {
return this.initiator().type.toLowerCase() as ResourceType;
throw new UnsupportedOperation();
}
override method(): string {

6
packages/puppeteer-core/src/bidi/HTTPResponse.ts
View File

@ -40,6 +40,12 @@ export class BidiHTTPResponse extends HTTPResponse {
}
#initialize() {
if (this.#data.fromCache) {
this.#request
.frame()
?.page()
.trustedEmitter.emit(PageEvent.RequestServedFromCache, this.#request);
}
this.#request.frame()?.page().trustedEmitter.emit(PageEvent.Response, this);
}

6
test/TestExpectations.json
View File

@ -2645,6 +2645,12 @@
"expectations": ["FAIL"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
},
{
"testIdPattern": "[network.spec] network Network Events Page.Events.RequestServedFromCache",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "webDriverBiDi"],
"expectations": ["PASS"]
},
{
"testIdPattern": "[network.spec] network Network Events Page.Events.Response",
"platforms": ["darwin", "linux", "win32"],