github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid instanceof Object check in isErrorLike (#8527)

Browse Source
This commit is contained in:
James Diefenderfer 2022-06-17 06:26:18 -07:00 committed by GitHub
parent f0c17378a0
commit 6cd5cd0439
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/util.ts
View File

@ -407,7 +407,9 @@ interface ErrorLike extends Error {
} }
export function isErrorLike(obj: unknown): obj is ErrorLike { export function isErrorLike(obj: unknown): obj is ErrorLike {
return obj instanceof Object && 'name' in obj && 'message' in obj; return (
typeof obj === 'object' && obj !== null && 'name' in obj && 'message' in obj
);
} }
export function isErrnoException(obj: unknown): obj is NodeJS.ErrnoException { export function isErrnoException(obj: unknown): obj is NodeJS.ErrnoException {