From 6e060ce0fd9197d591694f175b08b96fd9c5a5c8 Mon Sep 17 00:00:00 2001 From: Jarrod Overson Date: Mon, 15 Jun 2020 04:36:45 -0400 Subject: [PATCH] fix(connection): separate send/receive debug logging (#6017) This PR splits the logging for send and receive messages in to separate debug channels. This way it is easier to filter and takes advantage of debug's automated coloring to make it easier to visually parse on the command line --- src/Connection.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Connection.ts b/src/Connection.ts index 70f42cf5378..fcf33581c66 100644 --- a/src/Connection.ts +++ b/src/Connection.ts @@ -16,7 +16,8 @@ import { assert } from './helper'; import { Events } from './Events'; import * as debug from 'debug'; -const debugProtocol = debug('puppeteer:protocol'); +const debugProtocolSend = debug('puppeteer:protocol:SEND ►'); +const debugProtocolReceive = debug('puppeteer:protocol:RECV ◀'); import Protocol from './protocol'; import { ConnectionTransport } from './ConnectionTransport'; @@ -78,14 +79,14 @@ export class Connection extends EventEmitter { _rawSend(message: {}): number { const id = ++this._lastId; message = JSON.stringify(Object.assign({}, message, { id })); - debugProtocol('SEND ► ' + message); + debugProtocolSend(message); this._transport.send(message); return id; } async _onMessage(message: string): Promise { if (this._delay) await new Promise((f) => setTimeout(f, this._delay)); - debugProtocol('◀ RECV ' + message); + debugProtocolReceive(message); const object = JSON.parse(message); if (object.method === 'Target.attachedToTarget') { const sessionId = object.params.sessionId;