diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4ef68602cf8..8eb6e872ada 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -262,13 +262,14 @@ The following steps are needed to update the Chromium version. 1. Find a suitable Chromium revision Not all revisions have builds for all platforms, so we need to find one that does. - To do so, run `utils/check_availability.js -rb` to find the latest suitable beta Chromium revision (see `utils/check_availability.js -help` for more options). + To do so, run `utils/check_availability.js -rd` to find the latest suitable `dev` Chromium revision (see `utils/check_availability.js -help` for more options). 1. Update `src/revisions.ts` with the found revision number. 1. Update `versions.js` with the new Chromium-to-Puppeteer version mapping. 1. Run `npm run ensure-correct-devtools-protocol-revision`. If it fails, update `package.json` with the expected `devtools-protocol` version. -1. Run `npm run tsc` and `npm install` and ensure that all tests pass. If a test fails, [bisect](#bisecting-upstream-changes) the upstream cause of the failure, and either update the test expectations accordingly (if it was an intended change) or work around the changes in Puppeteer (if it’s not desirable to change Puppeteer’s observable behavior). -1. Commit and push your changes and open a pull request. +1. Run `npm run tsc` and `npm install`. +1. Run `npm run unit` and ensure that all tests pass. If a test fails, [bisect](#bisecting-upstream-changes) the upstream cause of the failure, and either update the test expectations accordingly (if it was an intended change) or work around the changes in Puppeteer (if it’s not desirable to change Puppeteer’s observable behavior). +1. Commit and push your changes and open a pull request. The commit message must contain the version in `Chromium ()` format to ensure that [pptr.dev](https://pptr.dev/) can parse it correctly, e.g. `'feat(chromium): roll to Chromium 90.0.4427.0 (r856583)'`. ### Bisecting upstream changes diff --git a/package.json b/package.json index 054aa29a58d..d2e79216e29 100644 --- a/package.json +++ b/package.json @@ -56,7 +56,7 @@ "license": "Apache-2.0", "dependencies": { "debug": "^4.1.0", - "devtools-protocol": "0.0.854822", + "devtools-protocol": "0.0.869402", "extract-zip": "^2.0.0", "https-proxy-agent": "^5.0.0", "node-fetch": "^2.6.1", diff --git a/src/revisions.ts b/src/revisions.ts index bd2f9046c39..521f35bd537 100644 --- a/src/revisions.ts +++ b/src/revisions.ts @@ -20,6 +20,6 @@ type Revisions = Readonly<{ }>; export const PUPPETEER_REVISIONS: Revisions = { - chromium: '856583', + chromium: '869685', firefox: 'latest', }; diff --git a/versions.js b/versions.js index eb06e30232b..ec7737cb886 100644 --- a/versions.js +++ b/versions.js @@ -17,6 +17,7 @@ const versionsPerRelease = new Map([ // This is a mapping from Chromium version => Puppeteer version. // In Chromium roll patches, use 'NEXT' for the Puppeteer version. + ['91.0.4469.0', 'NEXT'], ['90.0.4427.0', 'v8.0.0'], ['90.0.4403.0', 'v7.0.0'], ['89.0.4389.0', 'v6.0.0'],