From 73f5b806a323fee3b82c0de4d8ecb4fcf520d481 Mon Sep 17 00:00:00 2001 From: Tomas Alabes Date: Tue, 7 Nov 2017 20:16:22 -0800 Subject: [PATCH] fix(install): support for npm no_proxy (#1314) This patch adds support for npm `no_proxy` configuration for the installation script. --- install.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/install.js b/install.js index 97c0c4fa32a..f129887d363 100644 --- a/install.js +++ b/install.js @@ -36,10 +36,14 @@ if (revisionInfo.downloaded) // Override current environment proxy settings with npm configuration, if any. const NPM_HTTPS_PROXY = process.env.npm_config_https_proxy || process.env.npm_config_proxy; const NPM_HTTP_PROXY = process.env.npm_config_http_proxy || process.env.npm_config_proxy; +const NPM_NO_PROXY = process.env.npm_config_no_proxy; + if (NPM_HTTPS_PROXY) process.env.HTTPS_PROXY = NPM_HTTPS_PROXY; if (NPM_HTTP_PROXY) process.env.HTTP_PROXY = NPM_HTTP_PROXY; +if (NPM_NO_PROXY) + process.env.NO_PROXY = NPM_NO_PROXY; const allRevisions = Downloader.downloadedRevisions(); const DOWNLOAD_HOST = process.env.PUPPETEER_DOWNLOAD_HOST || process.env.npm_config_puppeteer_download_host;