github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: supress viewport errors for pages that do not support changing it (#11970)

Browse Source
This commit is contained in:
Alex Rudenko 2024-02-22 13:10:59 +01:00 committed by GitHub
parent 5bbee1068f
commit 753a954456
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/puppeteer-core/src/cdp/EmulationManager.ts
View File

@ -267,13 +267,23 @@ export class EmulationManager {
const hasTouch = viewport.hasTouch || false; const hasTouch = viewport.hasTouch || false;
await Promise.all([ await Promise.all([
client.send('Emulation.setDeviceMetricsOverride', { client
mobile, .send('Emulation.setDeviceMetricsOverride', {
width, mobile,
height, width,
deviceScaleFactor, height,
screenOrientation, deviceScaleFactor,
}), screenOrientation,
})
.catch(err => {
if (
err.message.includes('Target does not support metrics override')
) {
debugError(err);
return;
}
throw err;
}),
client.send('Emulation.setTouchEmulationEnabled', { client.send('Emulation.setTouchEmulationEnabled', {
enabled: hasTouch, enabled: hasTouch,
}), }),