github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix frameset clicks in WebDriver BiDi (#11952)

Browse Source
This commit is contained in:
Alex Rudenko 2024-02-19 15:30:21 +01:00 committed by GitHub
parent 3ae01c2534
commit 76143f328f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/puppeteer-core/src/bidi/ElementHandle.ts
View File

@ -68,7 +68,10 @@ export class BidiElementHandle<
@ElementHandle.bindIsolatedHandle @ElementHandle.bindIsolatedHandle
override async contentFrame(): Promise<BidiFrame | null> { override async contentFrame(): Promise<BidiFrame | null> {
using handle = (await this.evaluateHandle(element => { using handle = (await this.evaluateHandle(element => {
if (element instanceof HTMLIFrameElement) { if (
element instanceof HTMLIFrameElement ||
element instanceof HTMLFrameElement
) {
return element.contentWindow; return element.contentWindow;
} }
return; return;

7
test/TestExpectations.json
View File

@ -401,13 +401,6 @@
"parameters": ["firefox"], "parameters": ["firefox"],
"expectations": ["SKIP"] "expectations": ["SKIP"]
}, },
{
"testIdPattern": "[frame.spec] Frame specs Frame Management should click elements in a frameset",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"],
"expectations": ["FAIL"],
"comment": "New test for framesets. We probably do not want to support framesets in WebDriver BiDi in the long term."
},
{ {
"testIdPattern": "[frame.spec] Frame specs Frame Management should handle nested frames", "testIdPattern": "[frame.spec] Frame specs Frame Management should handle nested frames",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],