From 7e2b47c9748c46fcdd91a55c72d80ea33def2ff6 Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Fri, 11 Feb 2022 07:32:27 +0100 Subject: [PATCH] chore: fix deprecate command (#8000) --- .github/workflows/publish-on-tag.yml | 2 +- utils/get_deprecated_version_range.js | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish-on-tag.yml b/.github/workflows/publish-on-tag.yml index fc95356537b..65a0d1add28 100644 --- a/.github/workflows/publish-on-tag.yml +++ b/.github/workflows/publish-on-tag.yml @@ -25,7 +25,7 @@ jobs: npm publish DEPRECATED_RANGE=$(node utils/get_deprecated_version_range.js) echo "Deprecating old puppeteer versions: $DEPRECATED_RANGE" - npm deprecate puppeteer@\"$DEPRECATED_RANGE\" "Version no longer supported. Upgrade to @latest" + npm deprecate puppeteer@$DEPRECATED_RANGE "Version no longer supported. Upgrade to @latest" - name: Publish puppeteer-core env: NPM_TOKEN: ${{secrets.NPM_TOKEN_PUPPETEER_CORE}} diff --git a/utils/get_deprecated_version_range.js b/utils/get_deprecated_version_range.js index a0603c3d5e8..280bbf8ab0f 100644 --- a/utils/get_deprecated_version_range.js +++ b/utils/get_deprecated_version_range.js @@ -18,10 +18,13 @@ const { versionsPerRelease, lastMaintainedChromiumVersion, } = require('../versions.js'); -const version = versionsPerRelease.get(lastMaintainedChromiumVersion); +let version = versionsPerRelease.get(lastMaintainedChromiumVersion); if (version.toLowerCase() === 'next') { console.error('Unexpected NEXT Puppeteer version in versions.js'); process.exit(1); } -console.log('< ' + version); +if (version.startsWith('v')) { + version = version.substring(1); +} +console.log('<' + version); process.exit(0);