From 7f60e33a63f901ec07fbb6275d36e88811161c4b Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 20 Oct 2017 10:58:39 -0700 Subject: [PATCH] feat(Chromium): roll Chromium to r510398 (#1112) This roll includes revision https://crrev.com/510285 that fixes the clipping bug on retina displays. Fixes #733 --- package.json | 2 +- test/test.js | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 52229d7ebc5..a68ae180e31 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ "ws": "^3.0.0" }, "puppeteer": { - "chromium_revision": "510141" + "chromium_revision": "510398" }, "devDependencies": { "@types/debug": "0.0.30", diff --git a/test/test.js b/test/test.js index 26443dcda8a..96fd2eaeacb 100644 --- a/test/test.js +++ b/test/test.js @@ -2531,9 +2531,7 @@ describe('Page', function() { const screenshot = await page.screenshot({omitBackground: true}); expect(screenshot).toBeGolden('transparent.png'); })); - // Doesn't work on retina displays. - // @see https://github.com/GoogleChrome/puppeteer/issues/733 - xit('should work with odd clip size on Retina displays', SX(async function() { + it('should work with odd clip size on Retina displays', SX(async function() { const screenshot = await page.screenshot({ clip: { x: 0,