From 8aa6cb37d2443ff7fe2a1fd5d5adafdde4e9d165 Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Fri, 13 Oct 2023 09:20:19 +0200 Subject: [PATCH] fix: add InlineTextBox as a non-element a11y role (#11142) --- packages/puppeteer-core/src/cdp/AriaQueryHandler.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/puppeteer-core/src/cdp/AriaQueryHandler.ts b/packages/puppeteer-core/src/cdp/AriaQueryHandler.ts index fc3a2536b52..8e91566fd2f 100644 --- a/packages/puppeteer-core/src/cdp/AriaQueryHandler.ts +++ b/packages/puppeteer-core/src/cdp/AriaQueryHandler.ts @@ -23,6 +23,8 @@ import type {AwaitableIterable} from '../common/types.js'; import {assert} from '../util/assert.js'; import {AsyncIterableUtil} from '../util/AsyncIterableUtil.js'; +const NON_ELEMENT_NODE_ROLES = new Set(['StaticText', 'InlineTextBox']); + const queryAXTree = async ( client: CDPSession, element: ElementHandle, @@ -35,7 +37,7 @@ const queryAXTree = async ( role, }); return nodes.filter((node: Protocol.Accessibility.AXNode) => { - return !node.role || node.role.value !== 'StaticText'; + return !node.role || !NON_ELEMENT_NODE_ROLES.has(node.role.value); }); };