github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(performance): use Runtime.getProperties for improved performance (#12561)

Browse Source
This commit is contained in:
Alex Rudenko 2024-06-10 16:09:52 +02:00 committed by GitHub
parent 0b2999f7b1
commit 8b2059f82a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/puppeteer-core/src/cdp/JSHandle.ts
View File

@ -87,6 +87,23 @@ export class CdpJSHandle<T = unknown> extends JSHandle<T> {
override remoteObject(): Protocol.Runtime.RemoteObject { override remoteObject(): Protocol.Runtime.RemoteObject {
return this.#remoteObject; return this.#remoteObject;
} }
override async getProperties(): Promise<Map<string, JSHandle<unknown>>> {
// We use Runtime.getProperties rather than iterative version for
// improved performance as it allows getting everything at once.
const response = await this.client.send('Runtime.getProperties', {
objectId: this.#remoteObject.objectId!,
ownProperties: true,
});
const result = new Map<string, JSHandle>();
for (const property of response.result) {
if (!property.enumerable || !property.value) {
continue;
}
result.set(property.name, this.#world.createCdpHandle(property.value));
}
return result;
}
} }
/** /**