github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(types): improve type of predicate function (#6997)

Browse Source 
From the DefinitelyTyped @types/puppeteer package:

c43191a8f7/types/puppeteer/index.d.ts (L1883-L1885)
This commit is contained in:
Karl Horky 2021-04-06 21:39:12 +02:00 committed by Mathias Bynens
parent c39c81d016
commit 943477cc1e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/common/Page.ts
View File

@ -1408,7 +1408,7 @@ export class Page extends EventEmitter {
} }
async waitForRequest( async waitForRequest(
urlOrPredicate: string | Function, urlOrPredicate: string | ((req: HTTPRequest) => boolean | Promise<boolean>),
options: { timeout?: number } = {} options: { timeout?: number } = {}
): Promise<HTTPRequest> { ): Promise<HTTPRequest> {
const { timeout = this._timeoutSettings.timeout() } = options; const { timeout = this._timeoutSettings.timeout() } = options;
@ -1428,7 +1428,9 @@ export class Page extends EventEmitter {
} }
async waitForResponse( async waitForResponse(
urlOrPredicate: string | Function, urlOrPredicate:
| string
| ((res: HTTPResponse) => boolean | Promise<boolean>),
options: { timeout?: number } = {} options: { timeout?: number } = {}
): Promise<HTTPResponse> { ): Promise<HTTPResponse> {
const { timeout = this._timeoutSettings.timeout() } = options; const { timeout = this._timeoutSettings.timeout() } = options;