github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: disable flaky installation test on macos-13 (#12478)

Browse Source
This commit is contained in:
Alex Rudenko 2024-05-22 10:28:49 +02:00 committed by GitHub
parent d83d9a6ae2
commit 97a4951d52
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/installation/assets/puppeteer/puppeteer-in-extension.js
View File

@ -26,7 +26,8 @@ try {
); );
const worker = await workerTarget.worker(); const worker = await workerTarget.worker();
await new Promise(resolve => setTimeout(resolve, 1000)); // See https://crbug.com/341213355
await new Promise(resolve => setTimeout(resolve, 2000));
const result = await worker.evaluate(async url => { const result = await worker.evaluate(async url => {
return await globalThis.testConnect(url); return await globalThis.testConnect(url);

13
test/installation/src/puppeteer.spec.ts
View File

@ -70,7 +70,10 @@ describe('`puppeteer`', () => {
} }
}); });
it('runs in the extension', async function () { // Flaky on macos-13.
(platform() === 'darwin' ? it.skip : it)(
'runs in the extension',
async function () {
const examplePath = join(this.sandbox, 'puppeteer-in-extension'); const examplePath = join(this.sandbox, 'puppeteer-in-extension');
fs.cpSync(join(EXAMPLES_DIR, 'puppeteer-in-extension'), examplePath, { fs.cpSync(join(EXAMPLES_DIR, 'puppeteer-in-extension'), examplePath, {
recursive: true, recursive: true,
@ -86,12 +89,16 @@ describe('`puppeteer`', () => {
const server = await TestServer.create(examplePath); const server = await TestServer.create(examplePath);
try { try {
const script = await readAsset('puppeteer', 'puppeteer-in-extension.js'); const script = await readAsset(
'puppeteer',
'puppeteer-in-extension.js'
);
await this.runScript(script, 'mjs', [String(server.port)]); await this.runScript(script, 'mjs', [String(server.port)]);
} finally { } finally {
await server.stop(); await server.stop();
} }
}); }
);
}); });
// Skipping this test on Windows as windows runners are much slower. // Skipping this test on Windows as windows runners are much slower.