chore: add documentation for missing methods

* fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
This commit is contained in:
TASNEEM KOUSHAR 2021-05-26 20:07:38 +05:30 committed by GitHub
parent ea2b0d1f62
commit 9e0acebb75
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 27 additions and 19 deletions

View File

@ -75,7 +75,7 @@ export class EventEmitter implements CommonEventEmitter {
/** /**
* Remove an event listener. * Remove an event listener.
* @deprecated please use `off` instead. * @deprecated please use {@link EventEmitter.off} instead.
*/ */
removeListener(event: EventType, handler: Handler): EventEmitter { removeListener(event: EventType, handler: Handler): EventEmitter {
this.off(event, handler); this.off(event, handler);
@ -84,7 +84,7 @@ export class EventEmitter implements CommonEventEmitter {
/** /**
* Add an event listener. * Add an event listener.
* @deprecated please use `on` instead. * @deprecated please use {@link EventEmitter.on} instead.
*/ */
addListener(event: EventType, handler: Handler): EventEmitter { addListener(event: EventType, handler: Handler): EventEmitter {
this.on(event, handler); this.on(event, handler);

View File

@ -191,14 +191,16 @@ export class HTTPRequest {
} }
/** /**
* @returns the response for this request, if a response has been received. * @returns A matching `HTTPResponse` object, or null if the response has not
* been received yet.
*/ */
response(): HTTPResponse | null { response(): HTTPResponse | null {
return this._response; return this._response;
} }
/** /**
* @returns the frame that initiated the request. * @returns the frame that initiated the request, or null if navigating to
* error pages.
*/ */
frame(): Frame | null { frame(): Frame | null {
return this._frame; return this._frame;
@ -212,6 +214,7 @@ export class HTTPRequest {
} }
/** /**
* A `redirectChain` is a chain of requests initiated to fetch a resource.
* @remarks * @remarks
* *
* `redirectChain` is shared between all the requests of the same chain. * `redirectChain` is shared between all the requests of the same chain.

View File

@ -237,8 +237,8 @@ export class JSHandle<HandleObjectType = unknown> {
} }
/** /**
* Returns a JSON representation of the object. * @returns Returns a JSON representation of the object.If the object has a
* * `toJSON` function, it will not be called.
* @remarks * @remarks
* *
* The JSON is generated by running {@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify | JSON.stringify} * The JSON is generated by running {@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify | JSON.stringify}
@ -259,12 +259,13 @@ export class JSHandle<HandleObjectType = unknown> {
} }
/** /**
* Returns either `null` or the object handle itself, if the object handle is * @returns Either `null` or the object handle itself, if the object
* an instance of {@link ElementHandle}. * handle is an instance of {@link ElementHandle}.
*/ */
asElement(): ElementHandle | null { asElement(): ElementHandle | null {
// This always returns null, but subclasses can override this and return an /* This always returns null, but subclasses can override this and return an
// ElementHandle. ElementHandle.
*/
return null; return null;
} }
@ -568,8 +569,10 @@ export class ElementHandle<
`JSHandle#uploadFile can only be used in Node environments.` `JSHandle#uploadFile can only be used in Node environments.`
); );
} }
// This import is only needed for `uploadFile`, so keep it scoped here to avoid paying /*
// the cost unnecessarily. This import is only needed for `uploadFile`, so keep it scoped here to
avoid paying the cost unnecessarily.
*/
const path = await import('path'); const path = await import('path');
const fs = await helper.importFSModule(); const fs = await helper.importFSModule();
// Locate all files and confirm that they exist. // Locate all files and confirm that they exist.
@ -590,9 +593,10 @@ export class ElementHandle<
const { node } = await this._client.send('DOM.describeNode', { objectId }); const { node } = await this._client.send('DOM.describeNode', { objectId });
const { backendNodeId } = node; const { backendNodeId } = node;
// The zero-length array is a special case, it seems that DOM.setFileInputFiles does /* The zero-length array is a special case, it seems that
// not actually update the files in that case, so the solution is to eval the element DOM.setFileInputFiles does not actually update the files in that case,
// value to a new FileList directly. so the solution is to eval the element value to a new FileList directly.
*/
if (files.length === 0) { if (files.length === 0) {
await (this as ElementHandle<HTMLInputElement>).evaluate((element) => { await (this as ElementHandle<HTMLInputElement>).evaluate((element) => {
element.files = new DataTransfer().files; element.files = new DataTransfer().files;
@ -979,8 +983,9 @@ export interface PressOptions {
} }
function computeQuadArea(quad: Array<{ x: number; y: number }>): number { function computeQuadArea(quad: Array<{ x: number; y: number }>): number {
// Compute sum of all directed areas of adjacent triangles /* Compute sum of all directed areas of adjacent triangles
// https://en.wikipedia.org/wiki/Polygon#Simple_polygons https://en.wikipedia.org/wiki/Polygon#Simple_polygons
*/
let area = 0; let area = 0;
for (let i = 0; i < quad.length; ++i) { for (let i = 0; i < quad.length; ++i) {
const p1 = quad[i]; const p1 = quad[i];

View File

@ -835,7 +835,7 @@ export class Page extends EventEmitter {
* @remarks * @remarks
* Shortcut for {@link Frame.$ | Page.mainFrame().$(selector) }. * Shortcut for {@link Frame.$ | Page.mainFrame().$(selector) }.
* *
* @param selector - A * @param selector - A `selector` to query page for
* {@link https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors | selector} * {@link https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors | selector}
* to query page for. * to query page for.
*/ */

View File

@ -151,7 +151,7 @@ export class WebWorker extends EventEmitter {
/** /**
* The only difference between `worker.evaluate` and `worker.evaluateHandle` * The only difference between `worker.evaluate` and `worker.evaluateHandle`
* is that `worker.evaluateHandle` returns in-page object (JSHandle). If the * is that `worker.evaluateHandle` returns in-page object (JSHandle). If the
* function passed to the `worker.evaluateHandle` returns a [Promise], then * function passed to the `worker.evaluateHandle` returns a `Promise`, then
* `worker.evaluateHandle` would wait for the promise to resolve and return * `worker.evaluateHandle` would wait for the promise to resolve and return
* its value. Shortcut for * its value. Shortcut for
* `await worker.executionContext()).evaluateHandle(pageFunction, ...args)` * `await worker.executionContext()).evaluateHandle(pageFunction, ...args)`