github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: roll Chromium to r564778 (#2681)

Browse Source 
This roll includes:
- https://chromium-review.googlesource.com/c/v8/v8/+/1086372 - [inspector] postpone API interrupts during creation of injected script

This fixes worker flakiness.

Fixes #2632
This commit is contained in:
Joel Einbinder 2018-06-06 07:48:56 -07:00 committed by Andrey Lushnikov
parent 4bc23319a2
commit a058468948
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Worker.js
View File

@ -29,12 +29,6 @@ class Worker extends EventEmitter {
this._url = url; this._url = url;
this._executionContextPromise = new Promise(x => this._executionContextCallback = x); this._executionContextPromise = new Promise(x => this._executionContextCallback = x);
this._client.once('Runtime.executionContextCreated', async event => { this._client.once('Runtime.executionContextCreated', async event => {
// Get a reference to the main object on the worker as a hack around https://crbug.com/846099.
await this._client.send('Runtime.evaluate', {
expression: 'this',
returnByValue: false,
contextId: event.executionContextId
}).catch(debugError);
const jsHandleFactory = remoteObject => new JSHandle(executionContext, client, remoteObject); const jsHandleFactory = remoteObject => new JSHandle(executionContext, client, remoteObject);
const executionContext = new ExecutionContext(client, event.context, jsHandleFactory, null); const executionContext = new ExecutionContext(client, event.context, jsHandleFactory, null);
this._executionContextCallback(executionContext); this._executionContextCallback(executionContext);

2
package.json
View File

@ -8,7 +8,7 @@
"node": ">=6.4.0" "node": ">=6.4.0"
}, },
"puppeteer": { "puppeteer": {
"chromium_revision": "563942" "chromium_revision": "564778"
}, },
"scripts": { "scripts": {
"unit": "node test/test.js", "unit": "node test/test.js",