github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stricter eslint rules (#472)

Browse Source 
Accept stricter eslint rules.
This commit is contained in:
JoelEinbinder 2017-08-22 14:18:07 -07:00 committed by Andrey Lushnikov
parent ce08fc77b1
commit a526e9f9fb
4 changed files with 10 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
.eslintrc.js
View File

@ -43,11 +43,13 @@ module.exports = {
"getWithoutSet": false, "getWithoutSet": false,
"setWithoutGet": false "setWithoutGet": false
}], }],
"brace-style": [2, "1tbs", {"allowSingleLine": true}],
"curly": [2, "multi-or-nest", "consistent"], "curly": [2, "multi-or-nest", "consistent"],
"new-parens": 2, "new-parens": 2,
"func-call-spacing": 2, "func-call-spacing": 2,
"arrow-parens": [2, "as-needed"], "arrow-parens": [2, "as-needed"],
"prefer-const": 2, "prefer-const": 2,
"quote-props": [2, "consistent"],
// anti-patterns // anti-patterns
"no-var": 2, "no-var": 2,
@ -70,6 +72,7 @@ module.exports = {
"radix": 2, "radix": 2,
"valid-typeof": 2, "valid-typeof": 2,
"no-unused-vars": [2, { "args": "none", "vars": "local" }], "no-unused-vars": [2, { "args": "none", "vars": "local" }],
"no-implicit-globals": [2],
// es2015 features // es2015 features
"require-yield": 2, "require-yield": 2,
@ -102,23 +105,8 @@ module.exports = {
"no-trailing-spaces": 2, "no-trailing-spaces": 2,
"linebreak-style": [ 2, "unix" ], "linebreak-style": [ 2, "unix" ],
"indent": [2, 2, { "SwitchCase": 1, "CallExpression": {"arguments": 2}, "MemberExpression": 2 }], "indent": [2, 2, { "SwitchCase": 1, "CallExpression": {"arguments": 2}, "MemberExpression": 2 }],
"key-spacing": [2, {
/** "beforeColon": false
* Disabled, aspirational rules }]
*/
// brace-style is disabled, as eslint cannot enforce 1tbs as default, but allman for functions
"brace-style": [0, "allman", { "allowSingleLine": true }],
// key-spacing is disabled, as some objects use value-aligned spacing, some not.
"key-spacing": [0, {
"beforeColon": false,
"afterColon": true,
"align": "value"
}],
// quote-props is diabled, as property quoting styles are too varied to enforce.
"quote-props": [0, "as-needed"],
// no-implicit-globals will prevent accidental globals
"no-implicit-globals": [0]
} }
}; };

4
test/assets/injectedfile.js
View File

@ -1,2 +1,2 @@
__injected = 42; window.__injected = 42;
__injectedError = new Error('hi'); window.__injectedError = new Error('hi');

2
test/test.js
View File

@ -1849,7 +1849,7 @@ describe('Page', function() {
it('should allow transparency', SX(async function() { it('should allow transparency', SX(async function() {
await page.setViewport({ width: 100, height: 100 }); await page.setViewport({ width: 100, height: 100 });
await page.goto(EMPTY_PAGE); await page.goto(EMPTY_PAGE);
const screenshot = await page.screenshot({omitBackground:true}); const screenshot = await page.screenshot({omitBackground: true});
expect(screenshot).toBeGolden('transparent.png'); expect(screenshot).toBeGolden('transparent.png');
})); }));
}); });

2
utils/doclint/preprocessor/index.js
View File

@ -55,7 +55,7 @@ module.exports = function(sources) {
if (command.source.setText(newText)) if (command.source.setText(newText))
changedSources.add(command.source); changedSources.add(command.source);
} }
for (source of changedSources) for (const source of changedSources)
messages.push(Message.warning(`GEN: updated ${source.projectPath()}`)); messages.push(Message.warning(`GEN: updated ${source.projectPath()}`));
return messages; return messages;
}; };