github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: update expectations for Firefox when evaluate fails (#8890)

Browse Source
This commit is contained in:
Alex Rudenko 2022-09-02 11:41:34 +02:00 committed by GitHub
parent 2d50ec5b38
commit a870c258bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/src/page.spec.ts
View File

@ -1693,7 +1693,7 @@ describe('Page', function () {
}); });
it('should throw an error if loading from url fail', async () => { it('should throw an error if loading from url fail', async () => {
const {page, server} = getTestState(); const {page, server, isFirefox} = getTestState();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
let error!: Error; let error!: Error;
@ -1702,7 +1702,11 @@ describe('Page', function () {
} catch (error_) { } catch (error_) {
error = error_ as Error; error = error_ as Error;
} }
expect(error.message).toContain('Could not load script'); if (isFirefox) {
expect(error.message).toBeTruthy();
} else {
expect(error.message).toContain('Could not load script');
}
}); });
it('should work with a path', async () => { it('should work with a path', async () => {
@ -1815,7 +1819,7 @@ describe('Page', function () {
}); });
it('should throw an error if loading from url fail', async () => { it('should throw an error if loading from url fail', async () => {
const {page, server} = getTestState(); const {page, server, isFirefox} = getTestState();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
let error!: Error; let error!: Error;
@ -1824,7 +1828,11 @@ describe('Page', function () {
} catch (error_) { } catch (error_) {
error = error_ as Error; error = error_ as Error;
} }
expect(error.message).toContain('Could not load style'); if (isFirefox) {
expect(error.message).toBeTruthy();
} else {
expect(error.message).toContain('Could not load style');
}
}); });
it('should work with a path', async () => { it('should work with a path', async () => {