github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: rename secondary page to speculative session (#10817)

Browse Source
This commit is contained in:
Alex Rudenko 2023-08-30 15:07:11 +02:00 committed by GitHub
parent 8233f61a45
commit a9446f3d43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/puppeteer-core/src/common/EmulationManager.ts
View File

@ -43,7 +43,7 @@ export class EmulationManager {
this.#secondaryClients.delete(client); this.#secondaryClients.delete(client);
} }
async registerSecondaryPage(client: CDPSession): Promise<void> { async registerSpeculativeSession(client: CDPSession): Promise<void> {
this.#secondaryClients.add(client); this.#secondaryClients.add(client);
await this.#applyViewport(client); await this.#applyViewport(client);
client.once(CDPSessionEmittedEvents.Disconnected, () => { client.once(CDPSessionEmittedEvents.Disconnected, () => {

2
packages/puppeteer-core/src/common/FrameManager.ts
View File

@ -182,7 +182,7 @@ export class FrameManager extends EventEmitter {
} }
} }
async registerSecondaryPage(client: CDPSessionImpl): Promise<void> { async registerSpeculativeSession(client: CDPSessionImpl): Promise<void> {
await this.#networkManager.addClient(client); await this.#networkManager.addClient(client);
} }

8
packages/puppeteer-core/src/common/Page.ts
View File

@ -266,8 +266,12 @@ export class CDPPage extends Page {
if (session._target()._subtype() !== 'prerender') { if (session._target()._subtype() !== 'prerender') {
return; return;
} }
this.#frameManager.registerSecondaryPage(session).catch(debugError); this.#frameManager
this.#emulationManager.registerSecondaryPage(session).catch(debugError); .registerSpeculativeSession(session)
.catch(debugError);
this.#emulationManager
.registerSpeculativeSession(session)
.catch(debugError);
} }
); );
} }