From ac1767da0b4214ced548a62dd737e2863f92c715 Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Mon, 25 Mar 2024 09:44:11 +0100 Subject: [PATCH] fix: apply timeout to waiting for a response (#12142) --- packages/puppeteer-core/src/cdp/Frame.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/puppeteer-core/src/cdp/Frame.ts b/packages/puppeteer-core/src/cdp/Frame.ts index 740d53bea19..c7c2885a659 100644 --- a/packages/puppeteer-core/src/cdp/Frame.ts +++ b/packages/puppeteer-core/src/cdp/Frame.ts @@ -230,7 +230,13 @@ export class CdpFrame extends Frame { if (error) { throw error; } - return await watcher.navigationResponse(); + const result = await Deferred.race< + Error | HTTPResponse | null | undefined + >([watcher.terminationPromise(), watcher.navigationResponse()]); + if (result instanceof Error) { + throw error; + } + return result || null; } finally { watcher.dispose(); }