From ac55e69676dde4908e81c45f75cc84e0d3e850e9 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Thu, 2 Nov 2017 13:26:21 -0700 Subject: [PATCH] feat(Chromium): roll chromium to r513435. (#1259) This roll brings in a bunch of important patches: - crrev.com/512647 Changed headless browser profile dir to use Default profile path - crrev.com/512760 DevTools: stop idleness detector when pending navigation commits - crrev.com/512905 DevTools: introduce Page.getFrameTree - crrev.com/513373 DevTools: report loaderId in the lifecycle events - crrev.com/513419 DevTools: introduce Page.setLifecycleEventsEnabled - crrev.com/513422 DevTools: return loaderId from Page.navigate Fixes #921 BREAKING CHANGE: Headless user profile structure is changing. Custom profiles set with --user-data-dir flag will no longer be read in Chrome 63 and will have to be recreated. Alternatively, you can migrate old headless profile to a new structure. if you stored your profile in `` folder, you would run the following bash commands: ```bash cd mkdir Default mv * Default ``` Full headless-dev PSA announcement: https://groups.google.com/a/chromium.org/forum/#!msg/headless-dev/asX8WgktXIE/zTUfmHDcAQAJ --- lib/Page.js | 3 ++- package.json | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Page.js b/lib/Page.js index 3f7f048afbd..cbc15b0c872 100644 --- a/lib/Page.js +++ b/lib/Page.js @@ -43,10 +43,11 @@ class Page extends EventEmitter { const page = new Page(client, frameTree, ignoreHTTPSErrors, screenshotTaskQueue); await Promise.all([ + client.send('Page.setLifecycleEventsEnabled', { enabled: true }), client.send('Network.enable', {}), client.send('Runtime.enable', {}), client.send('Security.enable', {}), - client.send('Performance.enable', {}) + client.send('Performance.enable', {}), ]); if (ignoreHTTPSErrors) await client.send('Security.setOverrideCertificateErrors', {override: true}); diff --git a/package.json b/package.json index 97dba61b844..7ff20f5da21 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ "ws": "^3.0.0" }, "puppeteer": { - "chromium_revision": "511134" + "chromium_revision": "513435" }, "devDependencies": { "@types/debug": "0.0.30",