From acb6f83ab0f5b6746de2cc35aced970efb22168e Mon Sep 17 00:00:00 2001 From: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com> Date: Wed, 28 Feb 2024 17:45:11 +0100 Subject: [PATCH] test: remove isHeadless check (#12015) --- test/TestExpectations.json | 12 ++++++------ test/src/headful.spec.ts | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/TestExpectations.json b/test/TestExpectations.json index 0a0756efc49..b5c210ed99c 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -47,6 +47,12 @@ "parameters": ["webDriverBiDi"], "expectations": ["SKIP"] }, + { + "testIdPattern": "[headful.spec] *", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["firefox"], + "expectations": ["SKIP"] + }, { "testIdPattern": "[idle_override.spec] *", "platforms": ["darwin", "linux", "win32"], @@ -384,12 +390,6 @@ "parameters": ["webDriverBiDi"], "expectations": ["FAIL"] }, - { - "testIdPattern": "[headful.spec] *", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["cdp", "firefox"], - "expectations": ["SKIP"] - }, { "testIdPattern": "[idle_override.spec] *", "platforms": ["darwin", "linux", "win32"], diff --git a/test/src/headful.spec.ts b/test/src/headful.spec.ts index e5d109bb656..af7364d4149 100644 --- a/test/src/headful.spec.ts +++ b/test/src/headful.spec.ts @@ -12,11 +12,11 @@ import expect from 'expect'; import type {PuppeteerLaunchOptions} from 'puppeteer-core/internal/node/PuppeteerNode.js'; import {rmSync} from 'puppeteer-core/internal/node/util/fs.js'; -import {getTestState, isHeadless, launch} from './mocha-utils.js'; +import {getTestState, launch} from './mocha-utils.js'; const TMP_FOLDER = path.join(os.tmpdir(), 'pptr_tmp_folder-'); -(!isHeadless ? describe : describe.skip)('headful tests', function () { +describe('headful tests', function () { /* These tests fire up an actual browser so let's * allow a higher timeout */