github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DEBUG] More descriptive event reporting

Browse Source 
This patch improves DEBUG reporting so that circular event
arguments are shown with some information.
This commit is contained in:
Andrey Lushnikov 2017-07-29 13:02:56 -07:00
parent 0f3a0dcbfc
commit adf35952fc
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/helper.js
View File

@ -158,18 +158,23 @@ class Helper {
* @return {string} * @return {string}
*/ */
function stringifyArgument(arg) { function stringifyArgument(arg) {
if (typeof arg !== 'function') { if (Helper.isString(arg) || Helper.isNumber(arg) || !arg)
try { return JSON.stringify(arg);
return JSON.stringify(arg); if (typeof arg === 'function') {
} catch (e) { let text = arg.toString().split('\n').map(line => line.trim()).join('');
// The object was recursive if (text.length > 20)
return arg.toString(); text = text.substring(0, 20) + '…';
} return `"${text}"`;
} }
let text = arg.toString().split('\n').map(line => line.trim()).join(''); const state = {};
if (text.length > 20) const keys = Object.keys(arg);
text = text.substring(0, 20) + '…'; for (let key of keys) {
return `"${text}"`; const value = arg[key];
if (Helper.isString(value) || Helper.isNumber(value))
state[key] = JSON.stringify(value);
}
const name = arg.constructor.name === 'Object' ? '' : arg.constructor.name;
return name + JSON.stringify(state);
} }
} }