github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use randomized folder names for user profile directories (#364)

Browse Source 
This will make it much harder for puppeteer browsers to collide
on profile directories.

Fixes #360
This commit is contained in:
Andrey Lushnikov 2017-08-17 23:18:08 -07:00 committed by GitHub
parent 127f3966d7
commit ae14c1eee4
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Launcher.js
View File

@ -20,6 +20,7 @@ const Downloader = require('../utils/ChromiumDownloader');
const Connection = require('./Connection'); const Connection = require('./Connection');
const Browser = require('./Browser'); const Browser = require('./Browser');
const readline = require('readline'); const readline = require('readline');
const crypto = require('crypto');
const CHROME_PROFILE_PATH = path.resolve(__dirname, '..', '.dev_profile'); const CHROME_PROFILE_PATH = path.resolve(__dirname, '..', '.dev_profile');
let browserId = 0; let browserId = 0;
@ -49,8 +50,13 @@ class Launcher {
*/ */
static async launch(options) { static async launch(options) {
options = options || {}; options = options || {};
++browserId; let userDataDir = [
let userDataDir = CHROME_PROFILE_PATH + browserId; CHROME_PROFILE_PATH,
process.pid,
++browserId,
crypto.randomBytes(8 / 2).toString('hex') // add random salt 8 characters long.
].join('-');
let chromeArguments = DEFAULT_ARGS.concat([ let chromeArguments = DEFAULT_ARGS.concat([
`--user-data-dir=${userDataDir}`, `--user-data-dir=${userDataDir}`,
]); ]);