test: split headful spec (#11622)

test/TestExpectations.json

@@ -497,6 +497,30 @@
     "parameters": ["webDriverBiDi"],
     "expectations": ["FAIL", "PASS"]
   },
+  {
+    "testIdPattern": "[devtools.spec] DevTools should expose DevTools as a page",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["firefox"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[devtools.spec] DevTools should open devtools when \"devtools: true\" option is given",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["firefox"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[devtools.spec] DevTools target.page() should return a DevTools page if asPage is used",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["firefox"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[devtools.spec] DevTools target.page() should return a DevTools page if custom isPageTarget is provided",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["firefox"],
+    "expectations": ["SKIP"]
+  },
   {
     "testIdPattern": "[drag-and-drop.spec] *",
     "platforms": ["darwin", "linux", "win32"],
@@ -1903,6 +1927,24 @@
     "parameters": ["cdp", "firefox"],
     "expectations": ["SKIP"]
   },
+  {
+    "testIdPattern": "[extensions.spec] extensions background_page target type should be available",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "firefox"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[extensions.spec] extensions service_worker target type should be available",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "firefox"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[extensions.spec] extensions target.page() should return a background_page",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "firefox"],
+    "expectations": ["SKIP"]
+  },
   {
     "testIdPattern": "[fixtures.spec] Fixtures should close the browser when the node process closes",
     "platforms": ["darwin", "linux", "win32"],
@@ -1999,42 +2041,6 @@
     "parameters": ["cdp", "firefox"],
     "expectations": ["SKIP"]
   },
-  {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL headless should be able to read cookies written by headful",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["headful", "webDriverBiDi"],
-    "expectations": ["PASS"]
-  },
-  {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL should close browser with beforeunload page",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["headful", "webDriverBiDi"],
-    "expectations": ["PASS"]
-  },
-  {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL should have default url when launching browser",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["headful", "webDriverBiDi"],
-    "expectations": ["PASS"]
-  },
-  {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL target.page() should return a background_page",
-    "platforms": ["darwin", "win32"],
-    "parameters": ["cdp", "chrome"],
-    "expectations": ["FAIL", "PASS"]
-  },
-  {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL target.page() should return a DevTools page if custom isPageTarget is provided",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["chrome", "webDriverBiDi"],
-    "expectations": ["PASS"]
-  },
-  {
-    "testIdPattern": "[headful.spec] headful tests Page.bringToFront should work",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["chrome", "webDriverBiDi"],
-    "expectations": ["PASS"]
-  },
   {
     "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
     "platforms": ["darwin", "linux", "win32"],
@@ -2245,6 +2251,12 @@
     "parameters": ["firefox", "headless"],
     "expectations": ["FAIL", "PASS"]
   },
+  {
+    "testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.launch should close browser with beforeunload page",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "firefox"],
+    "expectations": ["SKIP"]
+  },
   {
     "testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.launch should filter out ignored default argument in Firefox",
     "platforms": ["linux"],
@@ -2936,6 +2948,12 @@
     "parameters": ["cdp", "firefox"],
     "expectations": ["SKIP"]
   },
+  {
+    "testIdPattern": "[page.spec] Page Page.bringToFront should work",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "firefox"],
+    "expectations": ["SKIP"]
+  },
   {
     "testIdPattern": "[page.spec] Page Page.client should return the client instance",
     "platforms": ["darwin", "linux", "win32"],
@@ -3771,16 +3789,52 @@
     "expectations": ["FAIL", "PASS"]
   },
   {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL OOPIF: should expose events within OOPIFs",
+    "testIdPattern": "[devtools.spec] DevTools should expose DevTools as a page",
-    "platforms": ["linux"],
+    "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "chrome", "headless"],
-    "expectations": ["FAIL", "PASS"]
+    "expectations": ["SKIP"]
   },
   {
-    "testIdPattern": "[headful.spec] headful tests HEADFUL target.page() should return a DevTools page if custom isPageTarget is provided",
+    "testIdPattern": "[devtools.spec] DevTools should open devtools when \"devtools: true\" option is given",
     "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["firefox", "headful", "webDriverBiDi"],
+    "parameters": ["cdp", "chrome", "headless"],
-    "expectations": ["FAIL"]
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[devtools.spec] DevTools target.page() should return a DevTools page if asPage is used",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "chrome", "headless"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[devtools.spec] DevTools target.page() should return a DevTools page if custom isPageTarget is provided",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "chrome", "headless"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[extensions.spec] extensions background_page target type should be available",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "chrome", "headless"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[extensions.spec] extensions service_worker target type should be available",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "chrome", "headless"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[extensions.spec] extensions target.page() should return a background_page",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "chrome", "headless"],
+    "expectations": ["SKIP"]
+  },
+  {
+    "testIdPattern": "[extensions.spec] extensions target.page() should return a background_page",
+    "platforms": ["win32"],
+    "parameters": ["cdp", "chrome", "headful"],
+    "expectations": ["FAIL", "PASS"]
   },
   {
     "testIdPattern": "[launcher.spec] Launcher specs Puppeteer Puppeteer.launch userDataDir option restores preferences",
@@ -3818,6 +3872,12 @@
     "parameters": ["cdp", "chrome", "headful"],
     "expectations": ["FAIL", "PASS"]
   },
+  {
+    "testIdPattern": "[page.spec] Page Page.bringToFront should work",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "chrome", "headless"],
+    "expectations": ["SKIP"]
+  },
   {
     "testIdPattern": "[requestinterception.spec] request interception Page.setRequestInterception should be abortable",
     "platforms": ["darwin", "linux", "win32"],

test/src/cdp/devtools.spec.ts

@@ -0,0 +1,123 @@
+/**
+ * @license
+ * Copyright 2018 Google Inc.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import expect from 'expect';
+import type {PuppeteerLaunchOptions} from 'puppeteer-core/internal/node/PuppeteerNode.js';
+
+import {getTestState, launch} from '../mocha-utils.js';
+
+describe('DevTools', function () {
+  /* These tests fire up an actual browser so let's
+   * allow a higher timeout
+   */
+  this.timeout(20_000);
+
+  let launchOptions: PuppeteerLaunchOptions & {
+    devtools: boolean;
+  };
+  const browsers: Array<() => Promise<void>> = [];
+
+  beforeEach(async () => {
+    const {defaultBrowserOptions} = await getTestState({
+      skipLaunch: true,
+    });
+    launchOptions = Object.assign({}, defaultBrowserOptions, {
+      devtools: true,
+    });
+  });
+
+  async function launchBrowser(options: any) {
+    const {browser, close} = await launch(options, {createContext: false});
+    browsers.push(close);
+    return browser;
+  }
+
+  afterEach(async () => {
+    await Promise.all(
+      browsers.map((close, index) => {
+        delete browsers[index];
+        return close();
+      })
+    );
+  });
+
+  it('target.page() should return a DevTools page if custom isPageTarget is provided', async function () {
+    const {puppeteer} = await getTestState({skipLaunch: true});
+    const originalBrowser = await launchBrowser(launchOptions);
+
+    const browserWSEndpoint = originalBrowser.wsEndpoint();
+
+    const browser = await puppeteer.connect({
+      browserWSEndpoint,
+      _isPageTarget(target) {
+        return (
+          target.type() === 'other' && target.url().startsWith('devtools://')
+        );
+      },
+    });
+    const devtoolsPageTarget = await browser.waitForTarget(target => {
+      return target.type() === 'other';
+    });
+    const page = (await devtoolsPageTarget.page())!;
+    expect(
+      await page.evaluate(() => {
+        return 2 * 3;
+      })
+    ).toBe(6);
+    expect(await browser.pages()).toContainEqual(page);
+  });
+  it('target.page() should return a DevTools page if asPage is used', async function () {
+    const {puppeteer} = await getTestState({skipLaunch: true});
+    const originalBrowser = await launchBrowser(launchOptions);
+
+    const browserWSEndpoint = originalBrowser.wsEndpoint();
+
+    const browser = await puppeteer.connect({
+      browserWSEndpoint,
+    });
+    const devtoolsPageTarget = await browser.waitForTarget(target => {
+      return target.type() === 'other';
+    });
+    const page = (await devtoolsPageTarget.asPage())!;
+    expect(
+      await page.evaluate(() => {
+        return 2 * 3;
+      })
+    ).toBe(6);
+    expect(await browser.pages()).toContainEqual(page);
+  });
+  it('should open devtools when "devtools: true" option is given', async () => {
+    const browser = await launchBrowser(
+      Object.assign({devtools: true}, launchOptions)
+    );
+    const context = await browser.createIncognitoBrowserContext();
+    await Promise.all([
+      context.newPage(),
+      browser.waitForTarget((target: {url: () => string | string[]}) => {
+        return target.url().includes('devtools://');
+      }),
+    ]);
+    await browser.close();
+  });
+  it('should expose DevTools as a page', async () => {
+    const browser = await launchBrowser(
+      Object.assign({devtools: true}, launchOptions)
+    );
+    const context = await browser.createIncognitoBrowserContext();
+    const [target] = await Promise.all([
+      browser.waitForTarget((target: {url: () => string | string[]}) => {
+        return target.url().includes('devtools://');
+      }),
+      context.newPage(),
+    ]);
+    const page = await target.page();
+    await page!.waitForFunction(() => {
+      // @ts-expect-error wrong context.
+      return Boolean(DevToolsAPI);
+    });
+    await browser.close();
+  });
+});

test/src/cdp/extensions.spec.ts

@@ -0,0 +1,120 @@
+/**
+ * @license
+ * Copyright 2018 Google Inc.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import path from 'path';
+
+import expect from 'expect';
+import type {PuppeteerLaunchOptions} from 'puppeteer-core/internal/node/PuppeteerNode.js';
+
+import {getTestState, launch} from '../mocha-utils.js';
+
+const extensionPath = path.join(
+  __dirname,
+  '..',
+  '..',
+  'assets',
+  'simple-extension'
+);
+const serviceWorkerExtensionPath = path.join(
+  __dirname,
+  '..',
+  '..',
+  'assets',
+  'serviceworkers',
+  'extension'
+);
+
+describe('extensions', function () {
+  /* These tests fire up an actual browser so let's
+   * allow a higher timeout
+   */
+  this.timeout(20_000);
+
+  let extensionOptions: PuppeteerLaunchOptions & {
+    args: string[];
+  };
+  const browsers: Array<() => Promise<void>> = [];
+
+  beforeEach(async () => {
+    const {defaultBrowserOptions} = await getTestState({
+      skipLaunch: true,
+    });
+
+    extensionOptions = Object.assign({}, defaultBrowserOptions, {
+      args: [
+        `--disable-extensions-except=${extensionPath}`,
+        `--load-extension=${extensionPath}`,
+      ],
+    });
+  });
+
+  async function launchBrowser(options: any) {
+    const {browser, close} = await launch(options, {createContext: false});
+    browsers.push(close);
+    return browser;
+  }
+
+  afterEach(async () => {
+    await Promise.all(
+      browsers.map((close, index) => {
+        delete browsers[index];
+        return close();
+      })
+    );
+  });
+
+  it('background_page target type should be available', async () => {
+    const browserWithExtension = await launchBrowser(extensionOptions);
+    const page = await browserWithExtension.newPage();
+    const backgroundPageTarget = await browserWithExtension.waitForTarget(
+      target => {
+        return target.type() === 'background_page';
+      }
+    );
+    await page.close();
+    await browserWithExtension.close();
+    expect(backgroundPageTarget).toBeTruthy();
+  });
+
+  it('service_worker target type should be available', async () => {
+    const browserWithExtension = await launchBrowser({
+      args: [
+        `--disable-extensions-except=${serviceWorkerExtensionPath}`,
+        `--load-extension=${serviceWorkerExtensionPath}`,
+      ],
+    });
+    const page = await browserWithExtension.newPage();
+    const serviceWorkerTarget = await browserWithExtension.waitForTarget(
+      target => {
+        return target.type() === 'service_worker';
+      }
+    );
+    await page.close();
+    await browserWithExtension.close();
+    expect(serviceWorkerTarget).toBeTruthy();
+  });
+
+  it('target.page() should return a background_page', async function () {
+    const browserWithExtension = await launchBrowser(extensionOptions);
+    const backgroundPageTarget = await browserWithExtension.waitForTarget(
+      target => {
+        return target.type() === 'background_page';
+      }
+    );
+    const page = (await backgroundPageTarget.page())!;
+    expect(
+      await page.evaluate(() => {
+        return 2 * 3;
+      })
+    ).toBe(6);
+    expect(
+      await page.evaluate(() => {
+        return (globalThis as any).MAGIC;
+      })
+    ).toBe(42);
+    await browserWithExtension.close();
+  });
+});

test/src/headful.spec.ts

@@ -9,7 +9,6 @@ import os from 'os';
 import path from 'path';
 
 import expect from 'expect';
-import {CDPSessionEvent} from 'puppeteer-core/internal/api/CDPSession.js';
 import type {PuppeteerLaunchOptions} from 'puppeteer-core/internal/node/PuppeteerNode.js';
 import {rmSync} from 'puppeteer-core/internal/node/util/fs.js';
 
@@ -17,15 +16,6 @@ import {getTestState, isHeadless, launch} from './mocha-utils.js';
 
 const TMP_FOLDER = path.join(os.tmpdir(), 'pptr_tmp_folder-');
 
-const extensionPath = path.join(__dirname, '../assets', 'simple-extension');
-const serviceWorkerExtensionPath = path.join(
-  __dirname,
-  '..',
-  'assets',
-  'serviceworkers',
-  'extension'
-);
-
 (!isHeadless ? describe : describe.skip)('headful tests', function () {
   /* These tests fire up an actual browser so let's
    * allow a higher timeout
@@ -34,23 +24,11 @@ const serviceWorkerExtensionPath = path.join(
 
   let headfulOptions: PuppeteerLaunchOptions | undefined;
   let headlessOptions: PuppeteerLaunchOptions & {headless: boolean};
-  let extensionOptions: PuppeteerLaunchOptions & {
+
-    headless: boolean;
-    args: string[];
-  };
-  let forcedOopifOptions: PuppeteerLaunchOptions & {
-    headless: boolean;
-    devtools: boolean;
-    args: string[];
-  };
-  let devtoolsOptions: PuppeteerLaunchOptions & {
-    headless: boolean;
-    devtools: boolean;
-  };
   const browsers: Array<() => Promise<void>> = [];
 
   beforeEach(async () => {
-    const {server, defaultBrowserOptions} = await getTestState({
+    const {defaultBrowserOptions} = await getTestState({
       skipLaunch: true,
     });
     headfulOptions = Object.assign({}, defaultBrowserOptions, {
@@ -59,31 +37,6 @@ const serviceWorkerExtensionPath = path.join(
     headlessOptions = Object.assign({}, defaultBrowserOptions, {
       headless: true,
     });
-
-    extensionOptions = Object.assign({}, defaultBrowserOptions, {
-      headless: false,
-      args: [
-        `--disable-extensions-except=${extensionPath}`,
-        `--load-extension=${extensionPath}`,
-      ],
-    });
-
-    forcedOopifOptions = Object.assign({}, defaultBrowserOptions, {
-      headless: false,
-      devtools: true,
-      args: [
-        `--host-rules=MAP oopifdomain 127.0.0.1`,
-        `--isolate-origins=${server.PREFIX.replace(
-          'localhost',
-          'oopifdomain'
-        )}`,
-      ],
-    });
-
-    devtoolsOptions = Object.assign({}, defaultBrowserOptions, {
-      headless: false,
-      devtools: true,
-    });
   });
 
   async function launchBrowser(options: any) {
@@ -102,108 +55,6 @@ const serviceWorkerExtensionPath = path.join(
   });
 
   describe('HEADFUL', function () {
-    it('background_page target type should be available', async () => {
-      const browserWithExtension = await launchBrowser(extensionOptions);
-      const page = await browserWithExtension.newPage();
-      const backgroundPageTarget = await browserWithExtension.waitForTarget(
-        target => {
-          return target.type() === 'background_page';
-        }
-      );
-      await page.close();
-      await browserWithExtension.close();
-      expect(backgroundPageTarget).toBeTruthy();
-    });
-    it('service_worker target type should be available', async () => {
-      const browserWithExtension = await launchBrowser({
-        headless: false,
-        args: [
-          `--disable-extensions-except=${serviceWorkerExtensionPath}`,
-          `--load-extension=${serviceWorkerExtensionPath}`,
-        ],
-      });
-      const page = await browserWithExtension.newPage();
-      const serviceWorkerTarget = await browserWithExtension.waitForTarget(
-        target => {
-          return target.type() === 'service_worker';
-        }
-      );
-      await page.close();
-      await browserWithExtension.close();
-      expect(serviceWorkerTarget).toBeTruthy();
-    });
-    it('target.page() should return a background_page', async function () {
-      const browserWithExtension = await launchBrowser(extensionOptions);
-      const backgroundPageTarget = await browserWithExtension.waitForTarget(
-        target => {
-          return target.type() === 'background_page';
-        }
-      );
-      const page = (await backgroundPageTarget.page())!;
-      expect(
-        await page.evaluate(() => {
-          return 2 * 3;
-        })
-      ).toBe(6);
-      expect(
-        await page.evaluate(() => {
-          return (globalThis as any).MAGIC;
-        })
-      ).toBe(42);
-      await browserWithExtension.close();
-    });
-    it('target.page() should return a DevTools page if custom isPageTarget is provided', async function () {
-      const {puppeteer} = await getTestState({skipLaunch: true});
-      const originalBrowser = await launchBrowser(devtoolsOptions);
-
-      const browserWSEndpoint = originalBrowser.wsEndpoint();
-
-      const browser = await puppeteer.connect({
-        browserWSEndpoint,
-        _isPageTarget(target) {
-          return (
-            target.type() === 'other' && target.url().startsWith('devtools://')
-          );
-        },
-      });
-      const devtoolsPageTarget = await browser.waitForTarget(target => {
-        return target.type() === 'other';
-      });
-      const page = (await devtoolsPageTarget.page())!;
-      expect(
-        await page.evaluate(() => {
-          return 2 * 3;
-        })
-      ).toBe(6);
-      expect(await browser.pages()).toContainEqual(page);
-    });
-    it('target.page() should return a DevTools page if asPage is used', async function () {
-      const {puppeteer} = await getTestState({skipLaunch: true});
-      const originalBrowser = await launchBrowser(devtoolsOptions);
-
-      const browserWSEndpoint = originalBrowser.wsEndpoint();
-
-      const browser = await puppeteer.connect({
-        browserWSEndpoint,
-      });
-      const devtoolsPageTarget = await browser.waitForTarget(target => {
-        return target.type() === 'other';
-      });
-      const page = (await devtoolsPageTarget.asPage())!;
-      expect(
-        await page.evaluate(() => {
-          return 2 * 3;
-        })
-      ).toBe(6);
-      expect(await browser.pages()).toContainEqual(page);
-    });
-    it('should have default url when launching browser', async function () {
-      const browser = await launchBrowser(extensionOptions);
-      const pages = (await browser.pages()).map((page: {url: () => any}) => {
-        return page.url();
-      });
-      expect(pages).toEqual(['about:blank']);
-    });
     it('headless should be able to read cookies written by headful', async () => {
       /* Needs investigation into why but this fails consistently on Windows CI. */
       const {server} = await getTestState({skipLaunch: true});
@@ -236,213 +87,5 @@ const serviceWorkerExtensionPath = path.join(
       } catch {}
       expect(cookie).toBe('foo=true');
     });
-    // TODO: Support OOOPIF. @see https://github.com/puppeteer/puppeteer/issues/2548
-    it.skip('OOPIF: should report google.com frame', async () => {
-      const {server} = await getTestState({skipLaunch: true});
-
-      // https://google.com is isolated by default in Chromium embedder.
-      const browser = await launchBrowser(headfulOptions);
-      const page = await browser.newPage();
-      await page.goto(server.EMPTY_PAGE);
-      await page.setRequestInterception(true);
-      page.on('request', (r: {respond: (arg0: {body: string}) => any}) => {
-        return r.respond({body: 'YO, GOOGLE.COM'});
-      });
-      await page.evaluate(() => {
-        const frame = document.createElement('iframe');
-        frame.setAttribute('src', 'https://google.com/');
-        document.body.appendChild(frame);
-        return new Promise(x => {
-          return (frame.onload = x);
-        });
-      });
-      await page.waitForSelector('iframe[src="https://google.com/"]');
-      const urls = page
-        .frames()
-        .map((frame: {url: () => any}) => {
-          return frame.url();
-        })
-        .sort();
-      expect(urls).toEqual([server.EMPTY_PAGE, 'https://google.com/']);
-    });
-    it('OOPIF: should expose events within OOPIFs', async () => {
-      const {server} = await getTestState({skipLaunch: true});
-      const browser = await launchBrowser(forcedOopifOptions);
-      const page = await browser.newPage();
-
-      // Setup our session listeners to observe OOPIF activity.
-      const session = await page.target().createCDPSession();
-      const networkEvents: any[] = [];
-      const otherSessions: any[] = [];
-      await session.send('Target.setAutoAttach', {
-        autoAttach: true,
-        flatten: true,
-        waitForDebuggerOnStart: true,
-      });
-      // TODO: Remove any.
-      (session as any).on(
-        CDPSessionEvent.SessionAttached,
-        async (session: {
-          on: (arg0: string, arg1: (params: any) => number) => void;
-          send: (arg0: string) => any;
-        }) => {
-          otherSessions.push(session);
-
-          session.on('Network.requestWillBeSent', (params: any) => {
-            return networkEvents.push(params);
-          });
-          await session.send('Network.enable');
-          await session.send('Runtime.runIfWaitingForDebugger');
-        }
-      );
-
-      // Navigate to the empty page and add an OOPIF iframe with at least one request.
-      await page.goto(server.EMPTY_PAGE);
-      await page.evaluate(
-        (frameUrl: string) => {
-          const frame = document.createElement('iframe');
-          frame.setAttribute('src', frameUrl);
-          document.body.appendChild(frame);
-          return new Promise((x, y) => {
-            frame.onload = x;
-            frame.onerror = y;
-          });
-        },
-        server.PREFIX.replace('localhost', 'oopifdomain') + '/one-style.html'
-      );
-      await page.waitForSelector('iframe');
-
-      // Ensure we found the iframe session.
-      expect(otherSessions).toHaveLength(1);
-
-      // Resume the iframe and trigger another request.
-      const iframeSession = otherSessions[0]!;
-      await iframeSession.send('Runtime.evaluate', {
-        expression: `fetch('/fetch')`,
-        awaitPromise: true,
-      });
-      await browser.close();
-
-      const requests = networkEvents.map(event => {
-        return event.request.url;
-      });
-      expect(requests).toContain(`http://oopifdomain:${server.PORT}/fetch`);
-    });
-    it('should close browser with beforeunload page', async () => {
-      const {server} = await getTestState({skipLaunch: true});
-      const browser = await launchBrowser(headfulOptions);
-      const page = await browser.newPage();
-
-      await page.goto(server.PREFIX + '/beforeunload.html');
-      // We have to interact with a page so that 'beforeunload' handlers
-      // fire.
-      await page.click('body');
-      await browser.close();
-    });
-    it('should open devtools when "devtools: true" option is given', async () => {
-      const browser = await launchBrowser(
-        Object.assign({devtools: true}, headfulOptions)
-      );
-      const context = await browser.createIncognitoBrowserContext();
-      await Promise.all([
-        context.newPage(),
-        browser.waitForTarget((target: {url: () => string | string[]}) => {
-          return target.url().includes('devtools://');
-        }),
-      ]);
-      await browser.close();
-    });
-    it('should expose DevTools as a page', async () => {
-      const browser = await launchBrowser(
-        Object.assign({devtools: true}, headfulOptions)
-      );
-      const context = await browser.createIncognitoBrowserContext();
-      const [target] = await Promise.all([
-        browser.waitForTarget((target: {url: () => string | string[]}) => {
-          return target.url().includes('devtools://');
-        }),
-        context.newPage(),
-      ]);
-      const page = await target.page();
-      await page!.waitForFunction(() => {
-        // @ts-expect-error wrong context.
-        return Boolean(DevToolsAPI);
-      });
-      await browser.close();
-    });
-  });
-
-  describe('Page.bringToFront', function () {
-    it('should work', async () => {
-      const browser = await launchBrowser(headfulOptions);
-      const page1 = await browser.newPage();
-      const page2 = await browser.newPage();
-
-      await page1.bringToFront();
-      expect(
-        await page1.evaluate(() => {
-          return document.visibilityState;
-        })
-      ).toBe('visible');
-      expect(
-        await page2.evaluate(() => {
-          return document.visibilityState;
-        })
-      ).toBe('hidden');
-
-      await page2.bringToFront();
-      expect(
-        await page1.evaluate(() => {
-          return document.visibilityState;
-        })
-      ).toBe('hidden');
-      expect(
-        await page2.evaluate(() => {
-          return document.visibilityState;
-        })
-      ).toBe('visible');
-
-      await page1.close();
-      await page2.close();
-      await browser.close();
-    });
-  });
-
-  describe('Page.screenshot', function () {
-    it('should run in parallel in multiple pages', async () => {
-      const {server} = await getTestState({skipLaunch: true});
-      const browser = await launchBrowser(headfulOptions);
-      const context = await browser.createIncognitoBrowserContext();
-
-      const N = 2;
-      const pages = await Promise.all(
-        Array(N)
-          .fill(0)
-          .map(async () => {
-            const page = await context.newPage();
-            await page.goto(server.PREFIX + '/grid.html');
-            return page;
-          })
-      );
-      const promises = [];
-      for (let i = 0; i < N; ++i) {
-        promises.push(
-          pages[i]!.screenshot({
-            clip: {x: 50 * i, y: 0, width: 50, height: 50},
-          })
-        );
-      }
-      const screenshots = await Promise.all(promises);
-      for (let i = 0; i < N; ++i) {
-        expect(screenshots[i]).toBeGolden(`grid-cell-${i}.png`);
-      }
-      await Promise.all(
-        pages.map(page => {
-          return page.close();
-        })
-      );
-
-      await browser.close();
-    });
   });
 });

test/src/launcher.spec.ts

@@ -112,6 +112,35 @@ describe('Launcher specs', function () {
         const {close} = await launch({});
         await close();
       });
+      it('should have default url when launching browser', async function () {
+        const {browser, close} = await launch({}, {createContext: false});
+        try {
+          const pages = (await browser.pages()).map(
+            (page: {url: () => any}) => {
+              return page.url();
+            }
+          );
+          expect(pages).toEqual(['about:blank']);
+        } finally {
+          await close();
+        }
+      });
+      it('should close browser with beforeunload page', async () => {
+        const {browser, server, close} = await launch(
+          {},
+          {createContext: false}
+        );
+        try {
+          const page = await browser.newPage();
+
+          await page.goto(server.PREFIX + '/beforeunload.html');
+          // We have to interact with a page so that 'beforeunload' handlers
+          // fire.
+          await page.click('body');
+        } finally {
+          await close();
+        }
+      });
       it('should reject all promises when browser is closed', async () => {
         const {page, close} = await launch({});
         let error!: Error;

test/src/oopif.spec.ts

@@ -6,6 +6,7 @@
 
 import expect from 'expect';
 import type {BrowserContext} from 'puppeteer-core/internal/api/BrowserContext.js';
+import {CDPSessionEvent} from 'puppeteer-core/internal/api/CDPSession.js';
 import type {CdpTarget} from 'puppeteer-core/internal/cdp/Target.js';
 
 import {getTestState, launch} from './mocha-utils.js';
@@ -440,6 +441,92 @@ describe('OOPIF', function () {
       });
     });
   });
+
+  it('should report google.com frame', async () => {
+    const {server, page} = state;
+    await page.goto(server.EMPTY_PAGE);
+    await page.setRequestInterception(true);
+    page.on('request', (r: {respond: (arg0: {body: string}) => any}) => {
+      return r.respond({body: 'YO, GOOGLE.COM'});
+    });
+    await page.evaluate(() => {
+      const frame = document.createElement('iframe');
+      frame.setAttribute('src', 'https://google.com/');
+      document.body.appendChild(frame);
+      return new Promise(x => {
+        return (frame.onload = x);
+      });
+    });
+    await page.waitForSelector('iframe[src="https://google.com/"]');
+    const urls = page
+      .frames()
+      .map((frame: {url: () => any}) => {
+        return frame.url();
+      })
+      .sort();
+    expect(urls).toEqual([server.EMPTY_PAGE, 'https://google.com/']);
+  });
+
+  it('should expose events within OOPIFs', async () => {
+    const {server, page} = state;
+
+    // Setup our session listeners to observe OOPIF activity.
+    const session = await page.target().createCDPSession();
+    const networkEvents: any[] = [];
+    const otherSessions: any[] = [];
+    await session.send('Target.setAutoAttach', {
+      autoAttach: true,
+      flatten: true,
+      waitForDebuggerOnStart: true,
+    });
+    // TODO: Remove any.
+    (session as any).on(
+      CDPSessionEvent.SessionAttached,
+      async (session: {
+        on: (arg0: string, arg1: (params: any) => number) => void;
+        send: (arg0: string) => any;
+      }) => {
+        otherSessions.push(session);
+
+        session.on('Network.requestWillBeSent', (params: any) => {
+          return networkEvents.push(params);
+        });
+        await session.send('Network.enable');
+        await session.send('Runtime.runIfWaitingForDebugger');
+      }
+    );
+
+    // Navigate to the empty page and add an OOPIF iframe with at least one request.
+    await page.goto(server.EMPTY_PAGE);
+    await page.evaluate(
+      (frameUrl: string) => {
+        const frame = document.createElement('iframe');
+        frame.setAttribute('src', frameUrl);
+        document.body.appendChild(frame);
+        return new Promise((x, y) => {
+          frame.onload = x;
+          frame.onerror = y;
+        });
+      },
+      server.PREFIX.replace('localhost', 'oopifdomain') + '/one-style.html'
+    );
+    await page.waitForSelector('iframe');
+
+    // Ensure we found the iframe session.
+    expect(otherSessions).toHaveLength(1);
+
+    // Resume the iframe and trigger another request.
+    const iframeSession = otherSessions[0]!;
+    await iframeSession.send('Runtime.evaluate', {
+      expression: `fetch('/fetch')`,
+      awaitPromise: true,
+    });
+
+    const requests = networkEvents.map(event => {
+      return event.request.url;
+    });
+    expect(requests).toContain(`http://oopifdomain:${server.PORT}/fetch`);
+  });
 });
 
 function oopifs(context: BrowserContext) {

test/src/page.spec.ts

@@ -2340,4 +2340,39 @@ describe('Page', function () {
       expect((page as CdpPage)._client()).toBeInstanceOf(CDPSession);
     });
   });
+
+  describe('Page.bringToFront', function () {
+    it('should work', async () => {
+      const {browser} = await getTestState();
+      const page1 = await browser.newPage();
+      const page2 = await browser.newPage();
+
+      await page1.bringToFront();
+      expect(
+        await page1.evaluate(() => {
+          return document.visibilityState;
+        })
+      ).toBe('visible');
+      expect(
+        await page2.evaluate(() => {
+          return document.visibilityState;
+        })
+      ).toBe('hidden');
+
+      await page2.bringToFront();
+      expect(
+        await page1.evaluate(() => {
+          return document.visibilityState;
+        })
+      ).toBe('hidden');
+      expect(
+        await page2.evaluate(() => {
+          return document.visibilityState;
+        })
+      ).toBe('visible');
+
+      await page1.close();
+      await page2.close();
+    });
+  });
 });

test/src/screenshot.spec.ts

@@ -359,6 +359,42 @@ describe('Screenshots', function () {
 
       expect(screenshot).toBeInstanceOf(Buffer);
     });
+
+    it('should run in parallel in multiple pages', async () => {
+      const {browser, server} = await getTestState();
+
+      const context = await browser.createIncognitoBrowserContext();
+
+      const N = 2;
+      const pages = await Promise.all(
+        Array(N)
+          .fill(0)
+          .map(async () => {
+            const page = await context.newPage();
+            await page.goto(server.PREFIX + '/grid.html');
+            return page;
+          })
+      );
+      const promises = [];
+      for (let i = 0; i < N; ++i) {
+        promises.push(
+          pages[i]!.screenshot({
+            clip: {x: 50 * i, y: 0, width: 50, height: 50},
+          })
+        );
+      }
+      const screenshots = await Promise.all(promises);
+      for (let i = 0; i < N; ++i) {
+        expect(screenshots[i]).toBeGolden(`grid-cell-${i}.png`);
+      }
+      await Promise.all(
+        pages.map(page => {
+          return page.close();
+        })
+      );
+
+      await context.close();
+    });
   });
 
   describe('Cdp', () => {