github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove the flag disabling bfcache (#11047)

Browse Source
This commit is contained in:
Alex Rudenko 2023-09-28 11:44:04 +02:00 committed by GitHub
parent 30bd030078
commit b0d7375519
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/puppeteer-core/src/node/ChromeLauncher.ts
View File

@ -177,7 +177,6 @@ export class ChromeLauncher extends ProductLauncher {
if (!USE_TAB_TARGET) { if (!USE_TAB_TARGET) {
disabledFeatures.push('Prerender2'); disabledFeatures.push('Prerender2');
disabledFeatures.push('BackForwardCache');
} }
const chromeArguments = [ const chromeArguments = [

18
test/TestExpectations.json
View File

@ -1019,6 +1019,12 @@
"parameters": ["webDriverBiDi"], "parameters": ["webDriverBiDi"],
"expectations": ["PASS"] "expectations": ["PASS"]
}, },
{
"testIdPattern": "[page.spec] Page Page.select should not throw when select causes navigation",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"],
"expectations": ["PASS"]
},
{ {
"testIdPattern": "[page.spec] Page Page.select should respect event bubbling", "testIdPattern": "[page.spec] Page Page.select should respect event bubbling",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
@ -3173,12 +3179,6 @@
"parameters": ["cdp", "firefox"], "parameters": ["cdp", "firefox"],
"expectations": ["FAIL"] "expectations": ["FAIL"]
}, },
{
"testIdPattern": "[page.spec] Page Page.select should not throw when select causes navigation",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"],
"expectations": ["PASS"]
},
{ {
"testIdPattern": "[page.spec] Page Page.select should work when re-defining top-level Event class", "testIdPattern": "[page.spec] Page Page.select should work when re-defining top-level Event class",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
@ -3862,11 +3862,5 @@
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "chrome", "headless"], "parameters": ["cdp", "chrome", "headless"],
"expectations": ["FAIL", "PASS"] "expectations": ["FAIL", "PASS"]
},
{
"testIdPattern": "[coverage.spec] Coverage specs JSCoverage resetOnNavigation should report scripts across navigations when disabled",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "chrome", "new-headless", "tabTarget"],
"expectations": ["FAIL"]
} }
] ]

2
test/src/coverage.spec.ts
View File

@ -165,6 +165,8 @@ describe('Coverage specs', function () {
await page.coverage.startJSCoverage({resetOnNavigation: false}); await page.coverage.startJSCoverage({resetOnNavigation: false});
await page.goto(server.PREFIX + '/jscoverage/multiple.html'); await page.goto(server.PREFIX + '/jscoverage/multiple.html');
// TODO: navigating too fast might loose JS coverage data in the browser.
await page.waitForNetworkIdle();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const coverage = await page.coverage.stopJSCoverage(); const coverage = await page.coverage.stopJSCoverage();
expect(coverage).toHaveLength(2); expect(coverage).toHaveLength(2);