github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Remove workaround for Firefox addIntercept contexts argument (#12159)

Browse Source
This commit is contained in:
Julian Descottes 2024-03-27 09:12:56 +01:00 committed by GitHub
parent 29637f2b8f
commit b144935789
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/puppeteer-core/src/bidi/BrowserContext.ts
View File

@ -185,11 +185,6 @@ export class BidiBrowserContext extends BrowserContext {
} }
try { try {
for (const page of await this.pages()) {
// Workaround for Firefox
// TODO: Remove once https://bugzilla.mozilla.org/show_bug.cgi?id=1882260 is fixed
await page.setRequestInterception(false);
}
await this.userContext.remove(); await this.userContext.remove();
} catch (error) { } catch (error) {
debugError(error); debugError(error);

5
packages/puppeteer-core/src/bidi/Page.ts
View File

@ -202,11 +202,6 @@ export class BidiPage extends Page {
override async close(options?: {runBeforeUnload?: boolean}): Promise<void> { override async close(options?: {runBeforeUnload?: boolean}): Promise<void> {
try { try {
if (this.#interception) {
// Workaround for Firefox
// TODO: Remove once https://bugzilla.mozilla.org/show_bug.cgi?id=1882260 is fixed
await this.setRequestInterception(false);
}
await this.#frame.browsingContext.close(options?.runBeforeUnload); await this.#frame.browsingContext.close(options?.runBeforeUnload);
} catch { } catch {
return; return;