chore(webdriver): don't swallow errors for session.new (#12499)

packages/puppeteer-core/src/bidi/core/Session.ts

@@ -7,7 +7,6 @@
 import type * as Bidi from 'chromium-bidi/lib/cjs/protocol/protocol.js';
 
 import {EventEmitter} from '../../common/EventEmitter.js';
-import {debugError} from '../../common/util.js';
 import {
   bubble,
   inertIfDisposed,
@@ -52,29 +51,9 @@ export class Session
     //   throw new Error(status.message);
     // }
 
-    let result;
-    try {
-      result = (
-        await connection.send('session.new', {
-          capabilities,
-        })
-      ).result;
-    } catch (err) {
-      // Chrome does not support session.new.
-      debugError(err);
-      result = {
-        sessionId: '',
-        capabilities: {
-          acceptInsecureCerts: false,
-          browserName: '',
-          browserVersion: '',
-          platformName: '',
-          setWindowRect: false,
-          webSocketUrl: '',
-          userAgent: '',
-        },
-      } satisfies Bidi.Session.NewResult;
-    }
+    const {result} = await connection.send('session.new', {
+      capabilities,
+    });
 
     const session = new Session(connection, result);
     await session.#initialize();

test/TestExpectations.json

@@ -1568,6 +1568,13 @@
     "expectations": ["SKIP"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
+  {
+    "testIdPattern": "[fixtures.spec] Fixtures should close the browser when the node process closes",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["chrome", "webDriverBiDi"],
+    "expectations": ["FAIL"],
+    "comment": "The browser `disconnect` event is not emitted"
+  },
   {
     "testIdPattern": "[frame.spec] Frame specs Frame Management should click elements in a frameset",
     "platforms": ["darwin", "linux", "win32"],

test/src/fixtures.spec.ts

@@ -101,9 +101,10 @@ describe('Fixtures', function () {
           wsEndPointCallback(output.substring(0, output.indexOf('\n')));
         }
       });
-      using browser = await puppeteer.connect({
+      const connectOptions = Object.assign({}, defaultBrowserOptions, {
         browserWSEndpoint: await wsEndPointPromise,
       });
+      using browser = await puppeteer.connect(connectOptions);
       const promises = [
         waitEvent(browser, 'disconnected'),
         new Promise(resolve => {