From b58ba6b07cd316f7a166e3c0c5a2d4ff9310b56a Mon Sep 17 00:00:00 2001
From: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
Date: Thu, 16 Nov 2023 08:16:40 +0100
Subject: [PATCH] chore: small fixes (#11397)

---
 .prettierignore                                  | 3 ++-
 packages/puppeteer-core/src/api/ElementHandle.ts | 1 -
 packages/puppeteer-core/src/cdp/IsolatedWorld.ts | 1 -
 test/TestExpectations.json                       | 6 ++++++
 tools/mocha-runner/src/mocha-runner.ts           | 2 ++
 5 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/.prettierignore b/.prettierignore
index f09db22539c..d24dd689d2e 100644
--- a/.prettierignore
+++ b/.prettierignore
@@ -52,4 +52,5 @@ versioned_*/
 
 # Ng-schematics
 /packages/ng-schematics/files/
-/packages/ng-schematics/sandbox/
\ No newline at end of file
+/packages/ng-schematics/sandbox/
+/packages/ng-schematics/multi/
diff --git a/packages/puppeteer-core/src/api/ElementHandle.ts b/packages/puppeteer-core/src/api/ElementHandle.ts
index e302ba1aa95..af0d855a63f 100644
--- a/packages/puppeteer-core/src/api/ElementHandle.ts
+++ b/packages/puppeteer-core/src/api/ElementHandle.ts
@@ -1356,7 +1356,6 @@ export abstract class ElementHandle<
 
     const page = this.frame.page();
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     await using _ =
       allowViewportExpansion && clip
         ? await page._createTemporaryViewportContainingBox(clip)
diff --git a/packages/puppeteer-core/src/cdp/IsolatedWorld.ts b/packages/puppeteer-core/src/cdp/IsolatedWorld.ts
index 38309cb72bf..95224a86101 100644
--- a/packages/puppeteer-core/src/cdp/IsolatedWorld.ts
+++ b/packages/puppeteer-core/src/cdp/IsolatedWorld.ts
@@ -162,7 +162,6 @@ export class IsolatedWorld extends Realm {
       return;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     using _ = await this.#mutex.acquire();
     try {
       await context._client.send(
diff --git a/test/TestExpectations.json b/test/TestExpectations.json
index cc5c610443d..08803c1511f 100644
--- a/test/TestExpectations.json
+++ b/test/TestExpectations.json
@@ -3635,6 +3635,12 @@
     "parameters": ["firefox", "headful", "webDriverBiDi"],
     "expectations": ["FAIL"]
   },
+  {
+    "testIdPattern": "[launcher.spec] Launcher specs Puppeteer Browser.disconnect should reject navigation when browser closes",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["cdp", "firefox", "headful"],
+    "expectations": ["FAIL", "PASS"]
+  },
   {
     "testIdPattern": "[navigation.spec] navigation \"after all\" hook in \"navigation\"",
     "platforms": ["darwin", "linux", "win32"],
diff --git a/tools/mocha-runner/src/mocha-runner.ts b/tools/mocha-runner/src/mocha-runner.ts
index f8e717a9d79..f84df1ababa 100644
--- a/tools/mocha-runner/src/mocha-runner.ts
+++ b/tools/mocha-runner/src/mocha-runner.ts
@@ -203,6 +203,8 @@ async function main() {
         !reporter ? path.join(__dirname, 'reporter.js') : reporter,
         '-O',
         `output=${tmpFilename}`,
+        '-n',
+        'trace-warnings',
       ];
 
       const specPattern = 'test/build/**/*.spec.js';