diff --git a/test/TestExpectations.json b/test/TestExpectations.json index bf06b1e7d2a..dd5d3bd694c 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -681,13 +681,6 @@ "expectations": ["FAIL"], "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" }, - { - "testIdPattern": "[page.spec] Page Page.setUserAgent *", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "Firefox does not support headers override" - }, { "testIdPattern": "[pdf.spec] Page.pdf *", "platforms": ["darwin", "linux", "win32"], @@ -1365,13 +1358,6 @@ "expectations": ["SKIP"], "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" }, - { - "testIdPattern": "[emulation.spec] Emulation Page.emulate should support clicking", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "Firefox does not support headers override" - }, { "testIdPattern": "[emulation.spec] Emulation Page.emulateCPUThrottling should change the CPU throttling rate successfully", "platforms": ["darwin", "linux", "win32"], @@ -3226,6 +3212,13 @@ "expectations": ["FAIL"], "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" }, + { + "testIdPattern": "[page.spec] Page Page.setUserAgent should work with additional userAgentMetdata", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["firefox", "webDriverBiDi"], + "expectations": ["FAIL"], + "comment": "Chrome-specific test" + }, { "testIdPattern": "[pdf.spec] Page.pdf can print to PDF with outline", "platforms": ["darwin", "linux", "win32"], @@ -3322,13 +3315,6 @@ "expectations": ["SKIP"], "comment": "TODO: Needs support for data URIs in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1805176" }, - { - "testIdPattern": "[requestinterception-experimental.spec] cooperative request interception Page.setRequestInterception should be able to remove headers", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "TODO: Needs investigation, on Firefox the test is passing even if the origin header is not removed" - }, { "testIdPattern": "[requestinterception-experimental.spec] cooperative request interception Page.setRequestInterception should be abortable with custom error codes", "platforms": ["darwin", "linux", "win32"], @@ -3385,13 +3371,6 @@ "expectations": ["SKIP"], "comment": "TODO: Needs support for enabling cache in BiDi without CDP https://github.com/w3c/webdriver-bidi/issues/582" }, - { - "testIdPattern": "[requestinterception-experimental.spec] cooperative request interception Page.setRequestInterception should work when header manipulation headers with redirect", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "TODO: Needs investigation, on Firefox the test is passing even if headers are not actually modified" - }, { "testIdPattern": "[requestinterception-experimental.spec] cooperative request interception Page.setRequestInterception should work with encoded server - 2", "platforms": ["darwin", "linux", "win32"], @@ -3475,13 +3454,6 @@ "expectations": ["SKIP"], "comment": "TODO: Needs support for data URIs in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1805176" }, - { - "testIdPattern": "[requestinterception.spec] request interception Page.setRequestInterception should be able to remove headers", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "TODO: Needs investigation, on Firefox the test is passing even if the origin header is not removed" - }, { "testIdPattern": "[requestinterception.spec] request interception Page.setRequestInterception should be abortable with custom error codes", "platforms": ["darwin", "linux", "win32"], @@ -3531,13 +3503,6 @@ "expectations": ["SKIP"], "comment": "TODO: Needs support for enabling cache in BiDi without CDP https://github.com/w3c/webdriver-bidi/issues/582" }, - { - "testIdPattern": "[requestinterception.spec] request interception Page.setRequestInterception should work when header manipulation headers with redirect", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["SKIP"], - "comment": "TODO: Needs investigation, on Firefox the test is passing even if headers are not actually modified" - }, { "testIdPattern": "[requestinterception.spec] request interception Page.setRequestInterception should work with encoded server - 2", "platforms": ["darwin", "linux", "win32"], diff --git a/test/src/requestinterception-experimental.spec.ts b/test/src/requestinterception-experimental.spec.ts index f8437b36d2f..48feba5f14f 100644 --- a/test/src/requestinterception-experimental.spec.ts +++ b/test/src/requestinterception-experimental.spec.ts @@ -178,7 +178,7 @@ describe('cooperative request interception', function () { page.on('request', request => { const headers = Object.assign({}, request.headers(), { foo: 'bar', - origin: undefined, // remove "origin" header + accept: undefined, // remove "accept" header }); void request.continue({headers}, 0); }); @@ -188,7 +188,7 @@ describe('cooperative request interception', function () { page.goto(server.PREFIX + '/empty.html'), ]); - expect(serverRequest.headers.origin).toBe(undefined); + expect(serverRequest.headers.accept).toBe(undefined); }); it('should contain referer header', async () => { const {page, server} = await getTestState();