From b8dbd28b8c90adad6893d56e110b503ff187f5c4 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 11 Aug 2017 01:07:33 -0700 Subject: [PATCH] Refer to the upstream bug (#239) The issue #168 is a protocol inconsistency which happens only in case of HTTPS error. This patch starts refering to the upstream bug instead of puppeteer issue. Closes #168. --- lib/NetworkManager.js | 4 ++-- test/test.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/NetworkManager.js b/lib/NetworkManager.js index 34c9001bcd5..798c50ae0e2 100644 --- a/lib/NetworkManager.js +++ b/lib/NetworkManager.js @@ -115,7 +115,7 @@ class NetworkManager extends EventEmitter { _onLoadingFinished(event) { let request = this._idToRequest.get(event.requestId); // For certain requestIds we never receive requestWillBeSent event. - // @see https://github.com/GoogleChrome/puppeteer/issues/168 + // @see https://crbug.com/750469 if (!request) return; request._completePromiseFulfill.call(null); @@ -129,7 +129,7 @@ class NetworkManager extends EventEmitter { _onLoadingFailed(event) { let request = this._idToRequest.get(event.requestId); // For certain requestIds we never receive requestWillBeSent event. - // @see https://github.com/GoogleChrome/puppeteer/issues/168 + // @see https://crbug.com/750469 if (!request) return; request._completePromiseFulfill.call(null); diff --git a/test/test.js b/test/test.js index 811a6538f37..18e7251145b 100644 --- a/test/test.js +++ b/test/test.js @@ -524,7 +524,7 @@ describe('Page', function() { })); it('should fail when navigating to bad SSL', SX(async function() { // Make sure that network events do not emit 'undefind'. - // @see https://github.com/GoogleChrome/puppeteer/issues/168 + // @see https://crbug.com/750469 page.on('request', request => expect(request).toBeTruthy()); page.on('requestfinished', request => expect(request).toBeTruthy()); page.on('requestfailed', request => expect(request).toBeTruthy());