github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(types): upgrade to TypeScript 3.1.1 (#3331)

Browse Source 
This upgrades  us to TypeScript 3.1.1, which fixes some build failures. Annoyingly TypeScript does a better job of checking `process.stdio`, which exposes that the DefinitelyTyped definition for it is wrong. See https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11587. I'll look into submitting a patch for that later.
This commit is contained in:
Joel Einbinder 2018-10-02 13:38:06 -07:00 committed by Andrey Lushnikov
parent 842fee860b
commit c237947b32
4 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/FrameManager.js
View File

@ -789,7 +789,7 @@ class Frame {
return this.waitForSelector(string, options); return this.waitForSelector(string, options);
} }
if (helper.isNumber(selectorOrFunctionOrTimeout)) if (helper.isNumber(selectorOrFunctionOrTimeout))
return new Promise(fulfill => setTimeout(fulfill, selectorOrFunctionOrTimeout)); return new Promise(fulfill => setTimeout(fulfill, /** @type {number} */ (selectorOrFunctionOrTimeout)));
if (typeof selectorOrFunctionOrTimeout === 'function') if (typeof selectorOrFunctionOrTimeout === 'function')
return this.waitForFunction(selectorOrFunctionOrTimeout, options, ...args); return this.waitForFunction(selectorOrFunctionOrTimeout, options, ...args);
return Promise.reject(new Error('Unsupported target type: ' + (typeof selectorOrFunctionOrTimeout))); return Promise.reject(new Error('Unsupported target type: ' + (typeof selectorOrFunctionOrTimeout)));

2
lib/Launcher.js
View File

@ -114,6 +114,7 @@ class Launcher {
} }
const usePipe = chromeArguments.includes('--remote-debugging-pipe'); const usePipe = chromeArguments.includes('--remote-debugging-pipe');
/** @type {!Array<"ignore"|"pipe">} */
const stdio = usePipe ? ['ignore', 'ignore', 'ignore', 'pipe', 'pipe'] : ['pipe', 'pipe', 'pipe']; const stdio = usePipe ? ['ignore', 'ignore', 'ignore', 'pipe', 'pipe'] : ['pipe', 'pipe', 'pipe'];
const chromeProcess = childProcess.spawn( const chromeProcess = childProcess.spawn(
chromeExecutable, chromeExecutable,
@ -163,6 +164,7 @@ class Launcher {
const transport = await WebSocketTransport.create(browserWSEndpoint); const transport = await WebSocketTransport.create(browserWSEndpoint);
connection = new Connection(browserWSEndpoint, transport, slowMo); connection = new Connection(browserWSEndpoint, transport, slowMo);
} else { } else {
// @ts-ignore - TypeScript incorrectly thinks stdio can't go above 2
const transport = new PipeTransport(/** @type {!NodeJS.WritableStream} */(chromeProcess.stdio[3]), /** @type {!NodeJS.ReadableStream} */ (chromeProcess.stdio[4])); const transport = new PipeTransport(/** @type {!NodeJS.WritableStream} */(chromeProcess.stdio[3]), /** @type {!NodeJS.ReadableStream} */ (chromeProcess.stdio[4]));
connection = new Connection('', transport, slowMo); connection = new Connection('', transport, slowMo);
} }

2
lib/Page.js
View File

@ -1019,7 +1019,7 @@ const supportedMetrics = new Set([
'JSHeapTotalSize', 'JSHeapTotalSize',
]); ]);
/** @enum {string} */ /** @enum {!{width: number, height: number}} */
Page.PaperFormats = { Page.PaperFormats = {
letter: {width: 8.5, height: 11}, letter: {width: 8.5, height: 11},
legal: {width: 8.5, height: 14}, legal: {width: 8.5, height: 14},

4
package.json
View File

@ -44,7 +44,7 @@
"@types/debug": "0.0.30", "@types/debug": "0.0.30",
"@types/extract-zip": "^1.6.2", "@types/extract-zip": "^1.6.2",
"@types/mime": "^2.0.0", "@types/mime": "^2.0.0",
"@types/node": "^8.0.26", "@types/node": "^8.10.32",
"@types/rimraf": "^2.0.2", "@types/rimraf": "^2.0.2",
"@types/ws": "^3.0.2", "@types/ws": "^3.0.2",
"commonmark": "^0.27.0", "commonmark": "^0.27.0",
@ -57,7 +57,7 @@
"pixelmatch": "^4.0.2", "pixelmatch": "^4.0.2",
"pngjs": "^3.3.3", "pngjs": "^3.3.3",
"text-diff": "^1.0.1", "text-diff": "^1.0.1",
"typescript": "^3.0.1" "typescript": "^3.1.1"
}, },
"browser": { "browser": {
"./lib/BrowserFetcher.js": false, "./lib/BrowserFetcher.js": false,