From c430138845a44e20bff88b49843569f119e08d3d Mon Sep 17 00:00:00 2001
From: Andrey Lushnikov <aslushnikov@gmail.com>
Date: Thu, 14 Jun 2018 16:42:10 -0700
Subject: [PATCH] test: drop PDF tests (#2744)

We fully rely on upstream PDF functionality. Our PDF tests are inferior
to those upstream and inconvenient to write.
---
 package.json      |  1 -
 test/page.spec.js | 68 +----------------------------------------------
 test/utils.js     | 33 -----------------------
 3 files changed, 1 insertion(+), 101 deletions(-)

diff --git a/package.json b/package.json
index bc22504ffd1..b016c37ef73 100644
--- a/package.json
+++ b/package.json
@@ -51,7 +51,6 @@
     "esprima": "^4.0.0",
     "minimist": "^1.2.0",
     "ncp": "^2.0.0",
-    "pdfjs-dist": "^1.8.595",
     "pixelmatch": "^4.0.2",
     "pngjs": "^3.3.3",
     "text-diff": "^1.0.1",
diff --git a/test/page.spec.js b/test/page.spec.js
index c29b98b17bc..daec420f4e6 100644
--- a/test/page.spec.js
+++ b/test/page.spec.js
@@ -16,7 +16,7 @@
 const fs = require('fs');
 const path = require('path');
 const utils = require('./utils');
-const {waitEvent, getPDFPages, cssPixelsToInches} = require('./utils');
+const {waitEvent} = require('./utils');
 
 module.exports.addTests = function({testRunner, expect, puppeteer, DeviceDescriptors, headless}) {
   const {describe, xdescribe, fdescribe} = testRunner;
@@ -1367,72 +1367,6 @@ module.exports.addTests = function({testRunner, expect, puppeteer, DeviceDescrip
       expect(fs.readFileSync(outputFile).byteLength).toBeGreaterThan(0);
       fs.unlinkSync(outputFile);
     });
-    it('should default to printing in Letter format', async({page, server}) => {
-      const pages = await getPDFPages(await page.pdf());
-      expect(pages.length).toBe(1);
-      expect(pages[0].width).toBeCloseTo(8.5, 2);
-      expect(pages[0].height).toBeCloseTo(11, 2);
-    });
-    it('should support setting custom format', async({page, server}) => {
-      const pages = await getPDFPages(await page.pdf({
-        format: 'a4'
-      }));
-      expect(pages.length).toBe(1);
-      expect(pages[0].width).toBeCloseTo(8.27, 1);
-      expect(pages[0].height).toBeCloseTo(11.7, 1);
-    });
-    it('should support setting paper width and height', async({page, server}) => {
-      const pages = await getPDFPages(await page.pdf({
-        width: '10in',
-        height: '10in',
-      }));
-      expect(pages.length).toBe(1);
-      expect(pages[0].width).toBeCloseTo(10, 2);
-      expect(pages[0].height).toBeCloseTo(10, 2);
-    });
-    it('should print multiple pages', async({page, server}) => {
-      await page.goto(server.PREFIX + '/grid.html');
-      // Define width and height in CSS pixels.
-      const width = 50 * 5 + 1;
-      const height = 50 * 5 + 1;
-      const pages = await getPDFPages(await page.pdf({width, height}));
-      expect(pages.length).toBe(8);
-      expect(pages[0].width).toBeCloseTo(cssPixelsToInches(width), 2);
-      expect(pages[0].height).toBeCloseTo(cssPixelsToInches(height), 2);
-    });
-    it('should support page ranges', async({page, server}) => {
-      await page.goto(server.PREFIX + '/grid.html');
-      // Define width and height in CSS pixels.
-      const width = 50 * 5 + 1;
-      const height = 50 * 5 + 1;
-      const pages = await getPDFPages(await page.pdf({width, height, pageRanges: '1,4-7'}));
-      expect(pages.length).toBe(5);
-    });
-    it('should throw if format is unknown', async({page, server}) => {
-      let error = null;
-      try {
-        await getPDFPages(await page.pdf({
-          format: 'something'
-        }));
-      } catch (e) {
-        error = e;
-      }
-      expect(error).toBeTruthy();
-      expect(error.message).toContain('Unknown paper format');
-    });
-    it('should throw if units are unknown', async({page, server}) => {
-      let error = null;
-      try {
-        await getPDFPages(await page.pdf({
-          width: '10em',
-          height: '10em',
-        }));
-      } catch (e) {
-        error = e;
-      }
-      expect(error).toBeTruthy();
-      expect(error.message).toContain('Failed to parse parameter value');
-    });
   });
 
   describe('Page.title', function() {
diff --git a/test/utils.js b/test/utils.js
index 55068cf5bed..eaadca62b82 100644
--- a/test/utils.js
+++ b/test/utils.js
@@ -81,37 +81,4 @@ const utils = module.exports = {
   waitEvent: function(emitter, eventName) {
     return new Promise(fulfill => emitter.once(eventName, fulfill));
   },
-
-  /**
-  * @param {!Buffer} pdfBuffer
-  * @return {!Promise<!Array<!Object>>}
-  */
-  getPDFPages: async function(pdfBuffer) {
-    const PDFJS = require('pdfjs-dist');
-    PDFJS.disableWorker = true;
-    const data = new Uint8Array(pdfBuffer);
-    const doc = await PDFJS.getDocument(data);
-    const pages = [];
-    for (let i = 0; i < doc.numPages; ++i) {
-      const page = await doc.getPage(i + 1);
-      const viewport = page.getViewport(1);
-      // Viewport width and height is in PDF points, which is
-      // 1/72 of an inch.
-      pages.push({
-        width: viewport.width / 72,
-        height: viewport.height / 72,
-      });
-      page.cleanup();
-    }
-    doc.cleanup();
-    return pages;
-  },
-
-  /**
-   * @param {number} px
-   * @return {number}
-   */
-  cssPixelsToInches: function(px) {
-    return px / 96;
-  },
 };