github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make browser._ensureChromeIsRunning idempotent

Browse Source 
The _ensureChromeIsRunning should launch chrome only once
and return the same promise for all its clients.
This commit is contained in:
Andrey Lushnikov 2017-07-06 18:20:01 -07:00
parent 6c7ae41ae6
commit c8664319ed
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Browser.js
View File

@ -63,6 +63,7 @@ class Browser {
this._chromeArguments.push(...options.args);
this._terminated = false;
this._chromeProcess = null;
this._launchPromise = null;
}
/**
@ -96,8 +97,12 @@ class Browser {
}
async _ensureChromeIsRunning() {
if (this._chromeProcess)
return;
if (!this._launchPromise)
this._launchPromise = this._launchChrome();
return this._launchPromise;
}
async _launchChrome() {
this._chromeProcess = childProcess.spawn(this._chromeExecutable, this._chromeArguments, {});
let stderr = '';
this._chromeProcess.stderr.on('data', data => stderr += data.toString('utf8'));