ci: optimize installation tests and inspect code (#11150)

.github/workflows/ci.yml

@@ -60,7 +60,6 @@ jobs:
           rm $diff_file
 
   check-changes:
-    needs: inspect-code
     uses: ./.github/workflows/changed-packages.yml
     with:
       check-mergeable-state: true

test/installation/src/puppeteer-firefox.spec.ts

@@ -16,12 +16,16 @@
 
 import assert from 'assert';
 import {readdir} from 'fs/promises';
+import {platform} from 'os';
 import {join} from 'path';
 
 import {configureSandbox} from './sandbox.js';
 import {readAsset} from './util.js';
 
-describe('`puppeteer` with Firefox', () => {
+// Skipping this test on Windows as windows runners are much slower.
+(platform() === 'win32' ? describe.skip : describe)(
+  '`puppeteer` with Firefox',
+  () => {
     configureSandbox({
       dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
       env: cwd => {
@@ -44,4 +48,5 @@ describe('`puppeteer` with Firefox', () => {
       const script = await readAsset('puppeteer-core', 'imports.js');
       await this.runScript(script, 'mjs');
     });
-});
+  }
+);

test/installation/src/puppeteer-typescript.spec.ts

@@ -15,12 +15,16 @@
  */
 
 import {readFile, writeFile} from 'fs/promises';
+import {platform} from 'os';
 import {join} from 'path';
 
 import {configureSandbox} from './sandbox.js';
 import {execFile, readAsset} from './util.js';
 
-describe('`puppeteer` with TypeScript', () => {
+// Skipping this test on Windows as windows runners are much slower.
+(platform() === 'win32' ? describe.skip : describe)(
+  '`puppeteer` with TypeScript',
+  () => {
     configureSandbox({
       dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
       devDependencies: ['typescript@4.7.4', '@types/node@16.3.3'],
@@ -51,4 +55,5 @@ describe('`puppeteer` with TypeScript', () => {
 
       await this.runScript(script, 'cjs');
     });
-});
+  }
+);

test/installation/src/puppeteer.spec.ts

@@ -17,6 +17,7 @@
 import assert from 'assert';
 import {readdirSync} from 'fs';
 import {readdir} from 'fs/promises';
+import {platform} from 'os';
 import {join} from 'path';
 
 import {configureSandbox} from './sandbox.js';
@@ -46,7 +47,10 @@ describe('`puppeteer`', () => {
   });
 });
 
-describe('`puppeteer` with PUPPETEER_DOWNLOAD_PATH', () => {
+// Skipping this test on Windows as windows runners are much slower.
+(platform() === 'win32' ? describe.skip : describe)(
+  '`puppeteer` with PUPPETEER_DOWNLOAD_PATH',
+  () => {
     configureSandbox({
       dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
       env: cwd => {
@@ -64,9 +68,13 @@ describe('`puppeteer` with PUPPETEER_DOWNLOAD_PATH', () => {
       const script = await readAsset('puppeteer', 'basic.js');
       await this.runScript(script, 'mjs');
     });
-});
+  }
+);
 
-describe('`puppeteer` clears cache', () => {
+// Skipping this test on Windows as windows runners are much slower.
+(platform() === 'win32' ? describe.skip : describe)(
+  '`puppeteer` clears cache',
+  () => {
     configureSandbox({
       dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
       env: cwd => {
@@ -99,4 +107,5 @@ describe('`puppeteer` clears cache', () => {
         1
       );
     });
-});
+  }
+);

test/installation/src/sandbox.ts

@@ -72,6 +72,7 @@ declare module 'mocha' {
  */
 export const configureSandbox = (options: SandboxOptions): void => {
   before(async function (): Promise<void> {
+    console.time('before');
     const sandbox = await mkdtemp(join(tmpdir(), 'puppeteer-'));
     const dependencies = (options.dependencies ?? []).map(module => {
       switch (module) {
@@ -125,13 +126,16 @@ export const configureSandbox = (options: SandboxOptions): void => {
       await writeFile(script, content);
       await execFile('node', [script], {cwd: sandbox, env});
     };
+    console.timeEnd('before');
   });
 
   after(async function () {
+    console.time('after');
     if (!process.env['KEEP_SANDBOX']) {
       await rm(this.sandbox, {recursive: true, force: true, maxRetries: 5});
     } else {
       console.log('sandbox saved in', this.sandbox);
     }
+    console.timeEnd('after');
   });
 };