github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Network): Do not attempt to normalize malformed URLs. (#875)

Browse Source 
This patch avoids throwing 'url malformed' error during generating
request hash for request interception.

Fixes #869.
This commit is contained in:
Andrey Lushnikov 2017-09-29 08:29:19 +09:00 committed by GitHub
parent ec760ab5e3
commit cfece3451d
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/NetworkManager.js
View File

@ -394,9 +394,16 @@ helper.tracePublicAPI(Response);
* @return {string}
*/
function generateRequestHash(request) {
const hash = {
let normalizedURL = request.url;
try {
// Decoding is necessary to normalize URLs. @see crbug.com/759388
url: decodeURI(request.url),
// The method will throw if the URL is malformed. In this case,
// consider URL to be normalized as-is.
normalizedURL = decodeURI(request.url);
} catch (e) {
}
const hash = {
url: normalizedURL,
method: request.method,
postData: request.postData,
headers: {},

7
test/test.js
View File

@ -979,6 +979,13 @@ describe('Page', function() {
const response = await page.goto(PREFIX + '/some nonexisting page');
expect(response.status).toBe(404);
}));
it('should work with badly encoded URLs', SX(async function() {
await page.setRequestInterceptionEnabled(true);
server.setRoute('/malformed?rnd=%911', (req, res) => res.end());
page.on('request', request => request.continue());
const response = await page.goto(PREFIX + '/malformed?rnd=%911');
expect(response.status).toBe(200);
}));
it('should work with encoded URLs - 2', SX(async function() {
// The requestWillBeSent will report URL as-is, whereas interception will
// report encoded URL for stylesheet. @see crbug.com/759388