github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(flakiness-dashboard): skip API Coverage for realz (#4843)

Browse Source
This commit is contained in:
Andrey Lushnikov 2019-08-13 16:23:41 -07:00 committed by GitHub
parent 5d2378f15b
commit d687c81cd5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/utils.js
View File

@ -19,6 +19,8 @@ const path = require('path');
const {FlakinessDashboard} = require('../utils/flakiness-dashboard'); const {FlakinessDashboard} = require('../utils/flakiness-dashboard');
const PROJECT_ROOT = fs.existsSync(path.join(__dirname, '..', 'package.json')) ? path.join(__dirname, '..') : path.join(__dirname, '..', '..'); const PROJECT_ROOT = fs.existsSync(path.join(__dirname, '..', 'package.json')) ? path.join(__dirname, '..') : path.join(__dirname, '..', '..');
const COVERAGE_TESTSUITE_NAME = '**API COVERAGE**';
/** /**
* @param {Map<string, boolean>} apiCoverage * @param {Map<string, boolean>} apiCoverage
* @param {Object} events * @param {Object} events
@ -57,7 +59,7 @@ const utils = module.exports = {
const coverage = new Map(); const coverage = new Map();
for (const [className, classType] of Object.entries(api)) for (const [className, classType] of Object.entries(api))
traceAPICoverage(coverage, events, className, classType); traceAPICoverage(coverage, events, className, classType);
testRunner.describe('COVERAGE', () => { testRunner.describe(COVERAGE_TESTSUITE_NAME, () => {
testRunner.it('should call all API methods', () => { testRunner.it('should call all API methods', () => {
const missingMethods = []; const missingMethods = [];
for (const method of coverage.keys()) { for (const method of coverage.keys()) {
@ -203,7 +205,7 @@ const utils = module.exports = {
testRunner.on('testfinished', test => { testRunner.on('testfinished', test => {
// Do not report tests from COVERAGE testsuite. // Do not report tests from COVERAGE testsuite.
// They don't bring much value to us. // They don't bring much value to us.
if (test.fullName.startsWith('COVERAGE')) if (test.fullName.includes(COVERAGE_TESTSUITE_NAME))
return; return;
const testpath = test.location.filePath.substring(utils.projectRoot().length); const testpath = test.location.filePath.substring(utils.projectRoot().length);
const url = `https://github.com/GoogleChrome/puppeteer/blob/${sha}/${testpath}#L${test.location.lineNumber}`; const url = `https://github.com/GoogleChrome/puppeteer/blob/${sha}/${testpath}#L${test.location.lineNumber}`;