github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Roll chromium to r491334 (#187)

Browse Source 
This patch rolls chromium to r491334

This revision includes @pavelfeldman changes to make dialogs
work in headless.
This commit is contained in:
Andrey Lushnikov 2017-08-02 13:12:44 -07:00 committed by GitHub
parent 5d647bf1fa
commit dbe8660082
3 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -29,7 +29,7 @@
"ws": "^3.0.0"
},
"puppeteer": {
"chromium_revision": "490379"
"chromium_revision": "491334"
},
"devDependencies": {
"commonmark": "^0.27.0",

8
test/test.js
View File

@ -755,14 +755,14 @@ describe('Page', function() {
});
describe('Page.Events.Dialog', function() {
it('should fire', function(done) {
it('should fire', SX(async function() {
page.on('dialog', dialog => {
expect(dialog.type).toBe('alert');
expect(dialog.message()).toBe('yo');
done();
dialog.accept();
});
page.evaluate(() => alert('yo'));
});
await page.evaluate(() => alert('yo'));
}));
// TODO Enable this when crbug.com/718235 is fixed.
(headless ? xit : it)('should allow accepting prompts', SX(async function(done) {
page.on('dialog', dialog => {

5
third_party/phantomjs/test/module/webpage/on-confirm.js vendored
View File

@ -30,7 +30,4 @@ test(function () {
page.onConfirm = undefined;
assert_equals(page.onConfirm, undefined);
}, "page.onConfirm", {
/* @see crbug.com/718235 */
expected_fail: true
});
}, "page.onConfirm");