github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(doclint): fix doclint tests (#941)

Browse Source 
Last commit 017429eef1 broke doclint
tests. Try bots didn't catch this because they were not running doclint
tests.

This patch:
- fixes doclint tests
- starts running doclint tests on travis
This commit is contained in:
Andrey Lushnikov 2017-10-02 15:14:57 -07:00 committed by GitHub
parent 017429eef1
commit dc4c8786e3
7 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.travis.yml
View File

@ -15,6 +15,7 @@ install:
script: script:
- 'if [ "$NODE7" = "true" ]; then yarn run lint; fi' - 'if [ "$NODE7" = "true" ]; then yarn run lint; fi'
- 'if [ "$NODE7" = "true" ]; then yarn run coverage; fi' - 'if [ "$NODE7" = "true" ]; then yarn run coverage; fi'
- 'if [ "$NODE7" = "true" ]; then yarn run test-doclint; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run test-node6-transformer; fi' - 'if [ "$NODE6" = "true" ]; then yarn run test-node6-transformer; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run build; fi' - 'if [ "$NODE6" = "true" ]; then yarn run build; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run unit-node6; fi' - 'if [ "$NODE6" = "true" ]; then yarn run unit-node6; fi'

2
utils/doclint/check_public_api/test/check-sorting/doc.md
View File

@ -10,8 +10,6 @@
#### foo.ddd #### foo.ddd
#### new Foo()
#### foo.ccc() #### foo.ccc()
#### foo.bbb() #### foo.bbb()

3
utils/doclint/check_public_api/test/check-sorting/result.txt
View File

@ -1,5 +1,4 @@
[MarkDown] Events should go first. Event 'b' in class Foo breaks order [MarkDown] Events should go first. Event 'b' in class Foo breaks order
[MarkDown] Constructor of Foo should go before other methods
[MarkDown] Event 'c' in class Foo breaks alphabetic ordering of events [MarkDown] Event 'c' in class Foo breaks alphabetic ordering of events
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.constructor() [MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.ccc()
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ccc() should go after Foo.bbb() [MarkDown] Bad alphabetic ordering of Foo members: Foo.ccc() should go after Foo.bbb()

8
utils/doclint/check_public_api/test/diff-arguments/doc.md
View File

@ -1,11 +1,11 @@
### class: Foo ### class: Foo
#### new Foo(arg1, arg2)
- `arg1` <[string]>
- `arg2` <[string]>
#### foo.bar(options) #### foo.bar(options)
- `options` <[Object]> - `options` <[Object]>
#### foo.foo(arg1, arg2)
- `arg1` <[string]>
- `arg2` <[string]>
#### foo.test(...files) #### foo.test(...files)
- `...filePaths` <[string]> - `...filePaths` <[string]>

2
utils/doclint/check_public_api/test/diff-arguments/foo.js
View File

@ -1,5 +1,5 @@
class Foo { class Foo {
constructor(arg1, arg3 = {}) { foo(arg1, arg3 = {}) {
} }
test(...filePaths) { test(...filePaths) {

2
utils/doclint/check_public_api/test/diff-arguments/result.txt
View File

@ -1,4 +1,4 @@
[MarkDown] Heading arguments for "foo.test(...files)" do not match described ones, i.e. "...files" != "...filePaths" [MarkDown] Heading arguments for "foo.test(...files)" do not match described ones, i.e. "...files" != "...filePaths"
[MarkDown] Method Foo.constructor() fails to describe its parameters: [MarkDown] Method Foo.foo() fails to describe its parameters:
- Argument not found: arg3 - Argument not found: arg3
- Non-existing argument found: arg2 - Non-existing argument found: arg2

1
utils/doclint/check_public_api/test/diff-properties/result.txt
View File

@ -1,3 +1,2 @@
[MarkDown] Method not found: Foo.constructor()
[MarkDown] Non-existing property found: Foo.c [MarkDown] Non-existing property found: Foo.c
[MarkDown] Property not found: Foo.b [MarkDown] Property not found: Foo.b