github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: kill browser process when 'taskkill' fails on Windows (#8352)

Browse Source
This commit is contained in:
Simon 2022-05-16 15:32:29 +02:00 committed by GitHub
parent 24dfbd5f7f
commit dccfadb90e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/node/BrowserRunner.ts
View File

@ -186,7 +186,14 @@ export class BrowserRunner {
if (this.proc && this.proc.pid && pidExists(this.proc.pid)) {
try {
if (process.platform === 'win32') {
childProcess.exec(`taskkill /pid ${this.proc.pid} /T /F`, () => {});
childProcess.exec(`taskkill /pid ${this.proc.pid} /T /F`, (error) => {
if (error) {
// taskkill can fail to kill the process e.g. due to missing permissions.
// Let's kill the process via Node API. This delays killing of all child
// proccesses of `this.proc` until the main Node.js process dies.
this.proc.kill();
}
});
} else {
// on linux the process group can be killed with the group id prefixed with
// a minus sign. The process group id is the group leader's pid.