github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(page): fix missing awaits in mouse.click (#4541)

Browse Source 
Lack of await causes dangling promises, which lead to unhandled rejections that cannot be caught if these calls fail (e.g. if the page is closed). 

References #4536
This commit is contained in:
Philip Bergqvist 2019-06-10 04:42:19 -04:00 committed by Andrey Lushnikov
parent 7faf1c9030
commit dd6fcfe77b
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Input.js
View File

@ -224,11 +224,20 @@ class Mouse {
*/ */
async click(x, y, options = {}) { async click(x, y, options = {}) {
const {delay = null} = options; const {delay = null} = options;
this.move(x, y); if (delay !== null) {
this.down(options); await Promise.all([
if (delay !== null) this.move(x, y),
this.down(options),
]);
await new Promise(f => setTimeout(f, delay)); await new Promise(f => setTimeout(f, delay));
await this.up(options); await this.up(options);
} else {
await Promise.all([
this.move(x, y),
this.down(options),
this.up(options),
]);
}
} }
/** /**