github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: restore WaitTask terminate condition (#9612)

Browse Source
This commit is contained in:
ggorlen 2023-02-01 00:10:02 -08:00 committed by GitHub
parent 40068a7d86
commit e16cbc6626
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/puppeteer-core/src/common/WaitTask.ts
View File

@ -177,10 +177,11 @@ export class WaitTask<T = unknown> {
async terminate(error?: unknown): Promise<void> { async terminate(error?: unknown): Promise<void> {
this.#world.taskManager.delete(this); this.#world.taskManager.delete(this);
if (error && !this.#result.finished()) {
if (this.#timeout) { if (this.#timeout) {
clearTimeout(this.#timeout); clearTimeout(this.#timeout);
} }
if (error && !this.#result.finished()) {
this.#result.reject(error); this.#result.reject(error);
} }