github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(puppeteer-core): target interceptor is not async (#9430)

Browse Source 
I found that the only call to `addTargetInterceptor` passes
`onAttachedToTarget` and is not async.
I also found a typo 🤓
This commit is contained in:
Darío Kondratiuk 2022-12-17 14:47:21 -03:00 committed by GitHub
parent 65aedcdfc4
commit e3e9cc622a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/puppeteer-core/src/common/ChromeTargetManager.ts
View File

@ -353,7 +353,7 @@ export class ChromeTargetManager extends EventEmitter implements TargetManager {
// present in #attachedTargetsBySessionId. // present in #attachedTargetsBySessionId.
assert(this.#attachedTargetsBySessionId.has(parentSession.id())); assert(this.#attachedTargetsBySessionId.has(parentSession.id()));
} }
await interceptor( interceptor(
target, target,
parentSession instanceof Connection parentSession instanceof Connection
? null ? null

2
packages/puppeteer-core/src/common/Page.ts
View File

@ -270,7 +270,7 @@ export class CDPPage extends Page {
this.emit(PageEmittedEvents.WorkerDestroyed, worker); this.emit(PageEmittedEvents.WorkerDestroyed, worker);
}; };
#onAttachedToTarget = async (createdTarget: Target) => { #onAttachedToTarget = (createdTarget: Target) => {
this.#frameManager.onAttachedToTarget(createdTarget); this.#frameManager.onAttachedToTarget(createdTarget);
if (createdTarget._getTargetInfo().type === 'worker') { if (createdTarget._getTargetInfo().type === 'worker') {
const session = createdTarget._session(); const session = createdTarget._session();

2
packages/puppeteer-core/src/common/TargetManager.ts
View File

@ -33,7 +33,7 @@ export type TargetFactory = (
export type TargetInterceptor = ( export type TargetInterceptor = (
createdTarget: Target, createdTarget: Target,
parentTarget: Target | null parentTarget: Target | null
) => Promise<void>; ) => void;
/** /**
* TargetManager encapsulates all interactions with CDP targets and is * TargetManager encapsulates all interactions with CDP targets and is

2
test/src/ariaqueryhandler.spec.ts
View File

@ -229,7 +229,7 @@ describe('AriaQueryHandler', () => {
await page.waitForSelector('aria/[role="button"]'); await page.waitForSelector('aria/[role="button"]');
}); });
it('should work for ElementHandler.waitForSelector', async () => { it('should work for ElementHandle.waitForSelector', async () => {
const {page, server} = getTestState(); const {page, server} = getTestState();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => { await page.evaluate(() => {