From e75ec2b016956edefa026a10e90812e758a3301b Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Tue, 16 Apr 2024 13:18:57 +0200 Subject: [PATCH] Revert " feat(webdriver): support Network interception" (#12278) --- docs/webdriver-bidi.md | 38 ++++++++++++++++++-------------------- test/TestExpectations.json | 20 ++++++++++++++------ 2 files changed, 32 insertions(+), 26 deletions(-) diff --git a/docs/webdriver-bidi.md b/docs/webdriver-bidi.md index 3e41f315c26..266bf018c69 100644 --- a/docs/webdriver-bidi.md +++ b/docs/webdriver-bidi.md @@ -18,8 +18,8 @@ Firefox integration is nearing feature parity with its previous CDP-based approa To gauge the capabilities of WebDriver BiDi, we utilized the comprehensive [Puppeteer test suite](https://puppeteer.github.io/ispuppeteerwebdriverbidiready/) -- For Firefox, there are currently under [30](https://puppeteer.github.io/ispuppeteerwebdriverbidiready/firefox-delta.json) failing tests compared to the CDP implementation, while over [140](https://puppeteer.github.io/ispuppeteerwebdriverbidiready/firefox-delta.json) new tests successfully utilize WebDriver BiDi, demonstrating its growing potential. -- For Chrome, around 85% of tests pass with WebDriver BiDi, indicating room for improvement compared to the CDP-based approach. +- For Firefox, there are currently under [60](https://puppeteer.github.io/ispuppeteerwebdriverbidiready/firefox-delta.json) failing tests compared to the CDP implementation, while over [82](https://puppeteer.github.io/ispuppeteerwebdriverbidiready/firefox-delta.json) new tests successfully utilize WebDriver BiDi, demonstrating its growing potential. +- For Chrome, around 68% of tests pass with WebDriver BiDi, indicating room for improvement compared to the CDP-based approach. ## Get started @@ -41,28 +41,17 @@ This is an exciting step towards a more unified and efficient cross-browser auto ## Puppeteer features supported over WebDriver BiDi -- Browser automation +- Browser and page automation - - Puppeteer.launch - Browser.close - - Browser.userAgent() - -- Page automation - + - Frame.goto() (except `referer` and `referrerPolicy`) - Page.bringToFront - Page.goBack() - Page.goForward() - Page.goto (except `referer` and `referrerPolicy`) - - Frame.goto() (except `referer` and `referrerPolicy`) - Page.reload (except for `ignoreCache` parameter) - Page.setViewport (`width`, `height`, `deviceScaleFactor` only) - - Page.cookies() - - Page.setCookie() - - Page.deleteCookie() - - Page.workers() - - PageEvent.WorkerCreated - - PageEvent.WorkerDestroyed - - Page.setExtraHTTPHeaders() + - Puppeteer.launch - [Script evaluation](https://pptr.dev/guides/evaluate-javascript): @@ -111,9 +100,13 @@ This is an exciting step towards a more unified and efficient cross-browser auto - BrowserContext.clearPermissionOverrides() - BrowserContext.overridePermissions() +## Puppeteer features not yet supported over WebDriver BiDi + - [Request interception](https://pptr.dev/guides/request-interception) - - HTTPRequest.abort() (no custom error support) + + - HTTPRequest.abort() - HTTPRequest.abortErrorReason() + - HTTPRequest.client() - HTTPRequest.continue() - HTTPRequest.continueRequestOverrides() - HTTPRequest.failure() @@ -124,8 +117,6 @@ This is an exciting step towards a more unified and efficient cross-browser auto - HTTPRequest.responseForRequest() - Page.setRequestInterception() -## Puppeteer features not yet supported over WebDriver BiDi - - Various emulations (most are supported with Chrome) - Page.emulate() (supported only in Chrome) @@ -143,7 +134,6 @@ This is an exciting step towards a more unified and efficient cross-browser auto - CDP-specific features - Page.createCDPSession() (supported only in Chrome) - - HTTPRequest.client() (supported only in Chrome) - Tracing (supported only in Chrome) - Coverage (supported only in Chrome) @@ -151,6 +141,7 @@ This is an exciting step towards a more unified and efficient cross-browser auto - Other methods: + - Browser.userAgent() - Frame.isOOPFrame() - Frame.waitForDevicePrompt() - HTTPResponse.buffer() @@ -161,6 +152,8 @@ This is an exciting step towards a more unified and efficient cross-browser auto - Input.dragOver() - Input.drop() - Page.authenticate() + - Page.cookies() + - Page.deleteCookie() - Page.emulateNetworkConditions() - Page.isDragInterceptionEnabled() - Page.isJavaScriptEnabled() (supported only in Chrome) @@ -169,10 +162,15 @@ This is an exciting step towards a more unified and efficient cross-browser auto - Page.queryObjects() (supported only in Chrome) - Page.screencast() (supported only in Chrome) - Page.setBypassServiceWorker() + - Page.setCookie() - Page.setDragInterception() + - Page.setExtraHTTPHeaders() - Page.setOfflineMode() - Page.setUserAgent() - Page.waitForDevicePrompt() - Page.waitForFileChooser() + - Page.workers() - PageEvent.popup + - PageEvent.WorkerCreated + - PageEvent.WorkerDestroyed - Target.opener() diff --git a/test/TestExpectations.json b/test/TestExpectations.json index ac93862a349..f6cbc8a7d61 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -2733,12 +2733,6 @@ "expectations": ["TIMEOUT"], "comment": "When navigating to page with authentication the command response (error) never comes without interception" }, - { - "testIdPattern": "[network.spec] network Page.setExtraHTTPHeaders should throw for non-string header values", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["firefox", "webDriverBiDi"], - "expectations": ["PASS"] - }, { "testIdPattern": "[network.spec] network Page.setExtraHTTPHeaders should work", "platforms": ["darwin", "linux", "win32"], @@ -3986,6 +3980,20 @@ "expectations": ["SKIP"], "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" }, + { + "testIdPattern": "[waittask.spec] waittask specs Frame.waitForSelector should survive cross-process navigation", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["chrome", "webDriverBiDi"], + "expectations": ["SKIP"], + "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" + }, + { + "testIdPattern": "[waittask.spec] waittask specs Frame.waitForSelector should survive cross-process navigation", + "platforms": ["darwin", "linux", "win32"], + "parameters": ["firefox", "webDriverBiDi"], + "expectations": ["SKIP"], + "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" + }, { "testIdPattern": "[waittask.spec] waittask specs Frame.waitForSelector should survive cross-process navigation", "platforms": ["darwin", "linux", "win32"],