From f3143a3d6005324654c6a0068dd8159a398814a0 Mon Sep 17 00:00:00 2001 From: JoelEinbinder Date: Thu, 17 Aug 2017 19:48:25 -0700 Subject: [PATCH] Fix flaky test (#351) The patch awaits the in-flight 'waitForElement' --- test/test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test.js b/test/test.js index 1796a1a9a90..d1866568acc 100644 --- a/test/test.js +++ b/test/test.js @@ -355,7 +355,7 @@ describe('Page', function() { await page.goto(EMPTY_PAGE); let frame = page.mainFrame(); let added = false; - frame.waitForSelector('div').then(() => added = true); + let watchdog = frame.waitForSelector('div').then(() => added = true); // run nop function.. await frame.evaluate(() => 42); // .. to be sure that waitForSelector promise is not resolved yet. @@ -363,6 +363,7 @@ describe('Page', function() { await frame.evaluate(addElement, 'br'); expect(added).toBe(false); await frame.evaluate(addElement, 'div'); + await watchdog; expect(added).toBe(true); }));