chore: BiDi close error (#10687)

packages/puppeteer-core/src/common/bidi/Page.ts

@@ -394,6 +394,10 @@ export class Page extends PageBase {
     return this.#networkManager.getNavigationResponse(id);
   }
 
+  override isClosed(): boolean {
+    return this.#closedDeferred.finished();
+  }
+
   override async close(): Promise<void> {
     if (this.#closedDeferred.finished()) {
       return;

test/TestExpectations.json

@@ -71,6 +71,12 @@
     "parameters": [],
     "expectations": ["PASS"]
   },
+  {
+    "testIdPattern": "[injected.spec] PuppeteerUtil tests *",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["webDriverBiDi"],
+    "expectations": ["PASS"]
+  },
   {
     "testIdPattern": "[jshandle.spec] *",
     "platforms": ["darwin", "linux", "win32"],
@@ -1181,6 +1187,18 @@
     "parameters": ["webDriverBiDi"],
     "expectations": ["PASS"]
   },
+  {
+    "testIdPattern": "[page.spec] Page Page.close should set the page close state",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["webDriverBiDi"],
+    "expectations": ["PASS"]
+  },
+  {
+    "testIdPattern": "[page.spec] Page Page.close should terminate network waiters",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["webDriverBiDi"],
+    "expectations": ["PASS"]
+  },
   {
     "testIdPattern": "[page.spec] Page Page.Events.Close should work with page.close",
     "platforms": ["darwin", "linux", "win32"],
@@ -3964,11 +3982,5 @@
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "chrome", "headless"],
     "expectations": ["FAIL", "PASS"]
-  },
-  {
-    "testIdPattern": "[injected.spec] PuppeteerUtil tests *",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["webDriverBiDi"],
-    "expectations": ["PASS"]
   }
 ]

test/src/launcher.spec.ts

@@ -107,7 +107,10 @@ describe('Launcher specs', function () {
           ]);
           for (let i = 0; i < 2; i++) {
             const message = results[i].message;
-            expect(message).toContain('Target closed');
+            expect(message).atLeastOneToContain([
+              'Target closed',
+              'Page closed!',
+            ]);
             expect(message).not.toContain('Timeout');
           }
         } finally {

test/src/page.spec.ts

@@ -110,7 +110,7 @@ describe('Page', function () {
       ]);
       for (let i = 0; i < 2; i++) {
         const message = results[i].message;
-        expect(message).toContain('Target closed');
+        expect(message).atLeastOneToContain(['Target closed', 'Page closed!']);
         expect(message).not.toContain('Timeout');
       }
     });