github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: test suggestions when skip exp + only test (#10090)

Browse Source
This commit is contained in:
Nikolay Vitkov 2023-04-27 08:00:23 +02:00 committed by GitHub
parent 1b125094b9
commit f6ae5764f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tools/mochaRunner/src/utils.ts
View File

@ -144,11 +144,24 @@ export function getExpectationUpdates(
pass
);
if (expectationEntry && !expectationEntry.expectations.includes('PASS')) {
addEntry({
expectation: expectationEntry,
action: 'remove',
basedOn: expectationEntry,
});
if (isWildCardPattern(expectationEntry.testIdPattern)) {
addEntry({
expectation: {
testIdPattern: getTestId(pass.file, pass.fullTitle),
platforms: context.platforms,
parameters: context.parameters,
expectations: ['PASS'],
},
action: 'add',
basedOn: expectationEntry,
});
} else {
addEntry({
expectation: expectationEntry,
action: 'remove',
basedOn: expectationEntry,
});
}
}
}
@ -163,7 +176,7 @@ export function getExpectationUpdates(
expectations,
failure
);
if (expectationEntry) {
if (expectationEntry && !expectationEntry.expectations.includes('SKIP')) {
if (
!expectationEntry.expectations.includes(
getTestResultForFailure(failure)
@ -197,7 +210,7 @@ export function getExpectationUpdates(
});
}
}
} else {
} else if (!expectationEntry) {
addEntry({
expectation: {
testIdPattern: getTestId(failure.file, failure.fullTitle),
@ -206,7 +219,6 @@ export function getExpectationUpdates(
expectations: [getTestResultForFailure(failure)],
},
action: 'add',
basedOn: expectationEntry,
});
}
}