From f8616ed54b9146a7e360035941c1aeb653a5737d Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 15 Jul 2019 17:53:27 -0700 Subject: [PATCH] fix(pipe): handle 'error' events on pipes to avoid crashing (#4705) Fix #4374 --- lib/PipeTransport.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PipeTransport.js b/lib/PipeTransport.js index a20df8584e3..fb87a97d219 100644 --- a/lib/PipeTransport.js +++ b/lib/PipeTransport.js @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -const {helper} = require('./helper'); +const {helper, debugError} = require('./helper'); /** * @implements {!Puppeteer.ConnectionTransport} @@ -31,7 +31,9 @@ class PipeTransport { helper.addEventListener(pipeRead, 'close', () => { if (this.onclose) this.onclose.call(null); - }) + }), + helper.addEventListener(pipeRead, 'error', debugError), + helper.addEventListener(pipeWrite, 'error', debugError), ]; this.onmessage = null; this.onclose = null;