From ff4f70f4ae7ca8deb0becbec2e49b35322dba336 Mon Sep 17 00:00:00 2001
From: Alex Rudenko <OrKoN@users.noreply.github.com>
Date: Fri, 12 Apr 2024 11:00:42 +0200
Subject: [PATCH] fix: remove NetworkServiceInProcess2 set by default (#12261)

Puppeteer has relied on this flag for a [long time](https://github.com/puppeteer/puppeteer/pull/3738) but it looks like it is not required anymore and it might lead to crashes in the latest versions of Chrome for desktop. This CL removes the flag.

Issue #12257
---
 packages/browsers/test/src/chrome/launch.spec.ts   | 1 -
 packages/browsers/test/src/chromium/launch.spec.ts | 1 -
 packages/puppeteer-core/src/node/ChromeLauncher.ts | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/browsers/test/src/chrome/launch.spec.ts b/packages/browsers/test/src/chrome/launch.spec.ts
index c420d9e0b6d..dc3d118d67f 100644
--- a/packages/browsers/test/src/chrome/launch.spec.ts
+++ b/packages/browsers/test/src/chrome/launch.spec.ts
@@ -77,7 +77,6 @@ describe('Chrome', () => {
         '--disable-renderer-backgrounding',
         '--disable-sync',
         '--enable-automation',
-        '--enable-features=NetworkServiceInProcess2',
         '--export-tagged-pdf',
         '--force-color-profile=srgb',
         '--headless=new',
diff --git a/packages/browsers/test/src/chromium/launch.spec.ts b/packages/browsers/test/src/chromium/launch.spec.ts
index 8cf7c8255b6..e382761981b 100644
--- a/packages/browsers/test/src/chromium/launch.spec.ts
+++ b/packages/browsers/test/src/chromium/launch.spec.ts
@@ -77,7 +77,6 @@ describe('Chromium', () => {
         '--disable-renderer-backgrounding',
         '--disable-sync',
         '--enable-automation',
-        '--enable-features=NetworkServiceInProcess2',
         '--export-tagged-pdf',
         '--force-color-profile=srgb',
         '--headless=new',
diff --git a/packages/puppeteer-core/src/node/ChromeLauncher.ts b/packages/puppeteer-core/src/node/ChromeLauncher.ts
index 8ff65b25309..9b71952a2eb 100644
--- a/packages/puppeteer-core/src/node/ChromeLauncher.ts
+++ b/packages/puppeteer-core/src/node/ChromeLauncher.ts
@@ -192,7 +192,7 @@ export class ChromeLauncher extends ProductLauncher {
 
     // Merge default enabled features with user-provided ones, if any.
     const enabledFeatures = [
-      'NetworkServiceInProcess2',
+      // Add features to enable by default here.
       ...userEnabledFeatures,
     ].filter(feature => {
       return feature !== '';