5 Commits

Author	SHA1	Message	Date
Jack Franklin	4b0fd8bc30	chore: upgrade to TypeScript 3.7 (#5562) ... TypeScript seems to struggle to understand `Promise.all` when the items in the array return different types. If we were authoring in TS we could fix this with TS generics (`Promise.all<OurTypeHere>(...)`) but for now we can typecast the result. We'll fix this properly when we author in TS.	2020-03-31 18:42:32 +02:00
Jack Franklin	29b626aa94	chore: upgrade TypeScript to 3.6 (#5559) ... Continues the work to get up to TS 3.8 (latest release at time of writing). This version of TS introduced built in definitions for web workers that include an `interface Worker` so TS gets confused when it sees us reference a `Worker`. I have renamed the imports to `PuppeteerWorker` as I couldn't figure out a way to tell TS to not load in the worker types; longer term we might consider renaming `Worker` to `PuppeteerWorker` (or an alternative) but that would be a breaking change that we don't need right now. The other fix is similar; TypeScript doesn't differentiate between the built-in `WebSocket` type and the `ws` library. Renaming the import solves this too.	2020-03-31 15:46:54 +02:00
Andrey Lushnikov	62733a20d7	fix(connection): bump websocket max received message size to 256Mb (#4571) ... This is the max message size that DevTools can emit over the DevTools protocol: https://cs.chromium.org/chromium/src/content/browser/devtools/devtools_http_handler.cc?type=cs&q=kSendBufferSizeForDevTools&sq=package:chromium&g=0&l=83 Test is failing on firefox since Firefox crashes when allocating 100Mb string. Fix #4543	2019-06-14 01:05:09 -07:00
Andrey Lushnikov	9c4b6d06e2	refactor: use browser-compliant interface of 'ws' (#3218) ... Bundled version of Puppeteer should rely on native WebSocket. Luckily, 'ws' module supports the same interface as the native browser websockets. This patch switches WebSocketTransport to use the browser-compliant interface of 'ws'. After this patch, I was able to bundle Puppeteer for browser using the following config in `package.json`: ```json "browser": { "./lib/BrowserFetcher.js": false, "ws": "./lib/BrowserWebSocket", "fs": false, "child_process": false, "rimraf": false, "readline": false } ``` where `./lib/BrowserWebSocket` is: ```js module.exports = WebSocket; ``` and the bundling command is: ```sh $ browserify -r ./index.js:puppeteer > ppweb.js ``` References #2119	2018-09-11 18:41:28 +01:00
Andrey Lushnikov	1b2c8113ba	refactor: move Connection to use ConnectionTransport (#3217) ... Currently connection assumes that transport is a websocket and tries to handle websocket-related errors. This patch: - moves ConnectionTransport interface to use callbacks instead of events. This way it could be used in browser context as well. - introduces WebSocketTransport that implements ConnectionTransport interface for ws. This is a preparation step for 2 things: - exposing `transport` option in the `puppeteer.connect` method - better support for `browserify` References #2119	2018-09-07 21:36:16 +01:00