puppeteer

github/puppeteer

Fork 0

mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Jack Franklin	ce34c0a4ff	fix: `page.goto` options type should be optional (#6038 ) The TypeScript definition erroneously made `options` required. We can fix it by providing a default value, which means users calling the function will be able to leave it blank without TS complaining. Issues like this are a +1 to porting our tests to TypeScript in order to catch these on our own test suite, so that's something we should look into.	2020-06-18 12:44:46 +01:00
Jack Franklin	086c08998b	chore: commit base new-docs (#5973 ) This adds the new docs that are generated by API Extractor via TSDoc. They are sparse because we do not yet use TSDoc in the codebase. This is the starting point and from here we can work through all the different classes and improve the documentation.	2020-06-04 15:56:45 +01:00

Jack Franklin

ce34c0a4ff

fix: page.goto options type should be optional (#6038 )

The TypeScript definition erroneously made `options` required. We can
fix it by providing a default value, which means users calling the
function will be able to leave it blank without TS complaining.

Issues like this are a +1 to porting our tests to TypeScript in order to
catch these on our own test suite, so that's something we should look into.

2020-06-18 12:44:46 +01:00

Jack Franklin

086c08998b

chore: commit base new-docs (#5973 )

This adds the new docs that are generated by API Extractor via TSDoc.
They are sparse because we do not yet use TSDoc in the codebase. This is
the starting point and from here we can work through all the different
classes and improve the documentation.

2020-06-04 15:56:45 +01:00

2 Commits